chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java - Issue 2447163004: [NTP Snippets] Pass "no suggestions" message from the backend to the UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2447163004: [NTP Snippets] Pass "no suggestions" message from the backend to the UI (Closed)

Patch Set: fix comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

index 6ad09d780b1fb9cbe7df840821935dcda256c609..f4981da5825a54a109560eadf1a9a949359aa7b4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

@@ -105,9 +105,9 @@ public class SignInPromo extends ChildNode implements StatusCardViewHolder.DataS

}

@Override

- @StringRes

- public int getDescription() {

- return R.string.snippets_disabled_signed_out_instructions;

+ public String getDescription() {

+ return ContextUtils.getApplicationContext().getString(

+ R.string.snippets_disabled_signed_out_instructions);

}

@Override

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java » ('j') | no next file with comments »