chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2447163004: [NTP Snippets] Pass "no suggestions" message from the backend to the UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2447163004: [NTP Snippets] Pass "no suggestions" message from the backend to the UI (Closed)

Patch Set: review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java » ('j') | components/ntp_snippets/category_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index bf5bab4db6e9203369e34d2477f88105f5f380ae..6b1a6d096d388fefcb08b9b18babc887a7785047 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -203,8 +203,10 @@ public class SnippetsBridge implements SuggestionsSource {

@CalledByNative

private static SuggestionsCategoryInfo createSuggestionsCategoryInfo(int category, String title,

- int cardLayout, boolean hasMoreButton, boolean showIfEmpty) {

- return new SuggestionsCategoryInfo(category, title, cardLayout, hasMoreButton, showIfEmpty);

+ int cardLayout, boolean hasMoreButton, boolean showIfEmpty,

+ String noSuggestionsMessage) {

+ return new SuggestionsCategoryInfo(

+ category, title, cardLayout, hasMoreButton, showIfEmpty, noSuggestionsMessage);

}

@CalledByNative