[parsing] When failing due to variable redeclaration, point at the variable.

[parsing] When failing due to variable redeclaration, point at the variable.

We used to point elsewhere, for instance the right-hand-side of an assignment.

Small limitation: Since variable proxies only have a start position, not an end
position, the best we can do is point at the first character.  (We cannot rely
on the scanner's last token position because Declare may be called long after
the variable has been scanned.)

R=adamk@chromium.org
BUG=v8:5572
Committed: https://crrev.com/8cd5592f54f423d0188ea1b88041ecf0511e3ad1
Cr-Commit-Position: refs/heads/master@{#40613}

[adamk, 2016-10-27 10:32:49]

lgtm % nits

https://codereview.chromium.org/2447143005/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2447143005/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1516: var_end_pos >= 0 ? var_end_pos :
declaration->proxy()->position() + 1);
var_end_pos != kNoSourcePosition

https://codereview.chromium.org/2447143005/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2447143005/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:471: Scope* declaration_scope = nullptr, int var_end_pos =
-1);
kNoSourcePosition

[neis, 2016-10-27 10:36:32]

The CQ bit was checked by neis@chromium.org

[neis, 2016-10-27 10:36:33]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2447143005/#ps20001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-10-27 10:36:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 11:03:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:15:10]

Description was changed from

==========
[parsing] When failing due to variable redeclaration, point at the variable.

We used to point elsewhere, for instance the right-hand-side of an assignment.

Small limitation: Since variable proxies only have a start position, not an end
position, the best we can do is point at the first character.  (We cannot rely
on the scanner's last token position because Declare may be called long after
the variable has been scanned.)

R=adamk@chromium.org
BUG=v8:5572
==========

to

==========
[parsing] When failing due to variable redeclaration, point at the variable.

We used to point elsewhere, for instance the right-hand-side of an assignment.

Small limitation: Since variable proxies only have a start position, not an end
position, the best we can do is point at the first character.  (We cannot rely
on the scanner's last token position because Declare may be called long after
the variable has been scanned.)

R=adamk@chromium.org
BUG=v8:5572

Committed: https://crrev.com/8cd5592f54f423d0188ea1b88041ecf0511e3ad1
Cr-Commit-Position: refs/heads/master@{#40613}
==========

[commit-bot: I haz the power, 2016-11-17 22:15:11]

Patchset 2 (id:??) landed as
https://crrev.com/8cd5592f54f423d0188ea1b88041ecf0511e3ad1
Cr-Commit-Position: refs/heads/master@{#40613}