Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: content/renderer/render_widget.cc

Issue 2447143003: Use kRenderClientId command line flag when starting a render process (Closed)
Patch Set: Removed SetFrameSinkID IPC; Using base::StringToInt() instead of std::stoi() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 57bb2085f61e3f419307f96fb827956bc7ba7206..0e63da2205d974fcf9931ed6759234bbce4a1c7b 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -18,6 +18,7 @@
#include "base/message_loop/message_loop.h"
#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h"
+#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/sys_info.h"
#include "base/trace_event/trace_event.h"
@@ -501,7 +502,6 @@ bool RenderWidget::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_SetTextDirection, OnSetTextDirection)
IPC_MESSAGE_HANDLER(ViewMsg_Move_ACK, OnRequestMoveAck)
IPC_MESSAGE_HANDLER(ViewMsg_UpdateScreenRects, OnUpdateScreenRects)
- IPC_MESSAGE_HANDLER(ViewMsg_SetFrameSinkId, OnSetFrameSinkId)
IPC_MESSAGE_HANDLER(ViewMsg_WaitForNextFrameForTests,
OnWaitNextFrameForTests)
IPC_MESSAGE_HANDLER(InputMsg_RequestCompositionUpdate,
@@ -1114,6 +1114,13 @@ void RenderWidget::initializeLayerTreeView() {
compositor_->SetNeverVisible();
StartCompositor();
+ DCHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kRendererClientId));
+ int32_t client_id;
+ base::StringToInt(base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+ switches::kRendererClientId),
+ &client_id);
+ compositor_->SetFrameSinkId(cc::FrameSinkId(client_id, routing_id_));
}
void RenderWidget::WillCloseLayerTreeView() {
@@ -1508,11 +1515,6 @@ void RenderWidget::OnUpdateWindowScreenRect(
window_screen_rect_ = window_screen_rect;
}
-void RenderWidget::OnSetFrameSinkId(const cc::FrameSinkId& frame_sink_id) {
- if (compositor_)
- compositor_->SetFrameSinkId(frame_sink_id);
-}
-
void RenderWidget::OnHandleCompositorProto(const std::vector<uint8_t>& proto) {
if (compositor_)
compositor_->OnHandleCompositorProto(proto);

Powered by Google App Engine
This is Rietveld 408576698