Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(174)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/password/autosignin.html
Issue
2447143002
:
Stop prerendering of a site if it uses the Credential Manager API. (Closed)
Patch Set: rebase
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/password_manager/chrome_password_manager_client.h
chrome/browser/password_manager/chrome_password_manager_client.cc
chrome/browser/prerender/prerender_browsertest.cc
chrome/browser/prerender/prerender_final_status.h
chrome/browser/prerender/prerender_final_status.cc
chrome/test/data/password/autosignin.html
components/password_manager/content/browser/credential_manager_impl.cc
components/password_manager/content/browser/credential_manager_impl_unittest.cc
components/password_manager/core/browser/password_manager_client.h
components/password_manager/core/browser/password_manager_client.cc
tools/metrics/histograms/histograms.xml
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/prerender/prerender_final_status.cc
('k') |
components/password_manager/content/browser/credential_manager_impl.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<head>
3
<script type="text/javascript">
4
window.onload = function() {
5
navigator.credentials.get({password: true})
6
.then(cred => window.location = '/password/done.html');
7
}
8
</script>
9
</head>
10
<body>
11
</body>
12
</html>
OLD
NEW
« no previous file with comments
|
« chrome/browser/prerender/prerender_final_status.cc
('k') |
components/password_manager/content/browser/credential_manager_impl.cc »
('j') |
no next file with comments »
Issue 2447143002: Stop prerendering of a site if it uses the Credential Manager API. (Closed)
Created 4 years, 1 month ago by vasilii
Modified 4 years, 1 month ago
Reviewers: mmenke, vabr (Chromium), Ilya Sherman, pasko
Base URL:
Comments: 17
This is Rietveld
408576698
Chromium Code Reviews
Issue 2447143002:
Stop prerendering of a site if it uses the Credential Manager API. (Closed)
