Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: net/url_request/url_request_job.h

Issue 2447083003: Move fail on suspend logic from URLRequestJob to TcpClientSocket.
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/transport_client_socket_pool.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job.h
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index 2341999ae5493b1e205343963b41d8cbc68549de..b568b7708e2cd8a54db13433a63c94cac99dcc57 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -13,7 +13,6 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
-#include "base/power_monitor/power_observer.h"
#include "net/base/host_port_pair.h"
#include "net/base/load_states.h"
#include "net/base/net_error_details.h"
@@ -44,11 +43,11 @@ class UploadDataStream;
class URLRequestStatus;
class X509Certificate;
-class NET_EXPORT URLRequestJob : public base::PowerObserver {
+class NET_EXPORT URLRequestJob {
public:
explicit URLRequestJob(URLRequest* request,
NetworkDelegate* network_delegate);
- ~URLRequestJob() override;
+ virtual ~URLRequestJob();
// Returns the request that owns this job.
URLRequest* request() const {
@@ -213,10 +212,6 @@ class NET_EXPORT URLRequestJob : public base::PowerObserver {
// See url_request.h for details.
virtual HostPortPair GetSocketAddress() const;
- // base::PowerObserver methods:
- // We invoke URLRequestJob::Kill on suspend (crbug.com/4606).
- void OnSuspend() override;
-
// Called after a NetworkDelegate has been informed that the URLRequest
// will be destroyed. This is used to track that no pending callbacks
// exist at destruction time of the URLRequestJob, unless they have been
« no previous file with comments | « net/socket/transport_client_socket_pool.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698