Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: net/socket/transport_client_socket_pool.cc

Issue 2447083003: Move fail on suspend logic from URLRequestJob to TcpClientSocket.
Patch Set: Fix connect error case Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/transport_client_socket_pool.cc
diff --git a/net/socket/transport_client_socket_pool.cc b/net/socket/transport_client_socket_pool.cc
index dbcd7c44c57b89da7e3d82f27c0eda464237850a..883e00409e9314cc25047d4e080a509095050a8f 100644
--- a/net/socket/transport_client_socket_pool.cc
+++ b/net/socket/transport_client_socket_pool.cc
@@ -300,6 +300,7 @@ int TransportConnectJob::DoTransportConnect() {
transport_socket_ = client_socket_factory_->CreateTransportClientSocket(
addresses_, std::move(socket_performance_watcher), net_log().net_log(),
net_log().source());
+ transport_socket_->SetFailOnSuspend(true);
// If the list contains IPv6 and IPv4 addresses, the first address will
// be IPv6, and the IPv4 addresses will be tried as fallback addresses,
@@ -390,6 +391,7 @@ void TransportConnectJob::DoIPv6FallbackTransportConnect() {
client_socket_factory_->CreateTransportClientSocket(
*fallback_addresses_, std::move(socket_performance_watcher),
net_log().net_log(), net_log().source());
+ fallback_transport_socket_->SetFailOnSuspend(true);
fallback_connect_start_time_ = base::TimeTicks::Now();
int rv = fallback_transport_socket_->Connect(
base::Bind(

Powered by Google App Engine
This is Rietveld 408576698