net/ftp/ftp_network_transaction.cc - Issue 2447083003: Move fail on suspend logic from URLRequestJob to TcpClientSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_network_transaction.cc

Issue 2447083003: Move fail on suspend logic from URLRequestJob to TcpClientSocket.

Patch Set: Fix connect error case Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ftp/ftp_network_transaction.cc

diff --git a/net/ftp/ftp_network_transaction.cc b/net/ftp/ftp_network_transaction.cc

index 8ecde3104de06e93f15218764c8ae756c40a1f6a..9216d494c75435b7fad48cfafa7e88298bdb03bd 100644

--- a/net/ftp/ftp_network_transaction.cc

+++ b/net/ftp/ftp_network_transaction.cc

@@ -655,6 +655,7 @@ int FtpNetworkTransaction::DoCtrlConnect() {

next_state_ = STATE_CTRL_CONNECT_COMPLETE;

ctrl_socket_ = socket_factory_->CreateTransportClientSocket(

addresses_, NULL, net_log_.net_log(), net_log_.source());

+ ctrl_socket_->SetFailOnSuspend(true);

net_log_.AddEvent(

NetLogEventType::FTP_CONTROL_CONNECTION,

ctrl_socket_->NetLog().source().ToEventParametersCallback());