Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl

Issue 2447033002: Support RTCConfiguration iceTransportPolicy (Closed)
Patch Set: update expectations Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl b/third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl
index 58ebd35b8003e3099b4a0394def77a4767a5e84f..fbd6d52b18c384c0a962aa7d11a798ca22fd4be7 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl
@@ -4,9 +4,9 @@
// https://w3c.github.io/webrtc-pc/#rtcicetransportpolicy-enum
-// TODO(foolip): This is called RTCIceTransportPolicy in the spec, and that enum
-// does not have "none" as one of its values.
-enum RTCIceTransports {
+// TODO(foolip): The spec does not have the "none" value.
+// https://crbug.com/659134
+enum RTCIceTransportPolicy {
"none",
"relay",
"all"
@@ -31,8 +31,12 @@ enum RTCRtcpMuxPolicy {
dictionary RTCConfiguration {
sequence<RTCIceServer> iceServers;
- // TODO(foolip): |iceTransports| should be |iceTransportPolicy|.
- RTCIceTransports iceTransports = "all";
+ // TODO(foolip): |iceTransportPolicy| default should be "all", but it is
+ // omitted to allow fallback to |iceTransports| if not specified.
+ RTCIceTransportPolicy iceTransportPolicy;
+ // TODO(foolip): |iceTransports| is not in the spec.
+ // https://crbug.com/659131
+ RTCIceTransportPolicy iceTransports;
RTCBundlePolicy bundlePolicy = "balanced";
// TODO(foolip): |rtcpMuxPolicy| default should be "require".
RTCRtcpMuxPolicy rtcpMuxPolicy;
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/modules/peerconnection/RTCIceServer.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698