Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2447023004:
[cleanup] #undef DECLARE_ERROR instead of non-existent DEFINE_ERROR (Closed)
|
Created:
4 years, 1 month ago by Henrique Ferreiro Modified:
4 years, 1 month ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[cleanup] #undef DECLARE_ERROR instead of non-existent DEFINE_ERROR
The latter was left from a previous commit and not updated later to reflect the new name.
Committed: https://crrev.com/2c38023be38ff4f78130879f589a8da6b6f619c6
Cr-Commit-Position: refs/heads/master@{#40620}
Patch Set 1 #Patch Set 2 : [cleanup] #undef DECLARE_ERROR instead of non-existent DEFINE_ERROR #Messages
Total messages: 21 (8 generated)
henrique.ferreiro@gmail.com changed reviewers: + aklein@chromium.org, caitp@igalia.com
henrique.ferreiro@gmail.com changed reviewers: + adamk@chromium.org - aklein@chromium.org
On 2016/10/26 12:17:03, hferreiro wrote: LGTM, but need a googler to check the CLA and approve for CQ
On 2016/10/26 12:47:48, caitp wrote: > On 2016/10/26 12:17:03, hferreiro wrote: > > LGTM, but need a googler to check the CLA and approve for CQ Also, a bit more detail in the description might be nice
CLA is all set, but agree with Caitlin regarding the CL description. See https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list... for some general suggestions on CL descriptions.
Description was changed from ========== undef typo BUG= ========== to ========== The former was left from a previous commit and not updated later to reflect the new name. ==========
On 2016/10/26 at 14:30:45, adamk wrote: > CLA is all set, but agree with Caitlin regarding the CL description. See > https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list... for some general suggestions on CL descriptions. I have updated the description. I hope it is ok now.
Description was changed from ========== The former was left from a previous commit and not updated later to reflect the new name. ========== to ========== The latter was left from a previous commit and not updated later to reflect the new name. ==========
On 2016/10/27 11:58:46, hferreiro wrote: > On 2016/10/26 at 14:30:45, adamk wrote: > > CLA is all set, but agree with Caitlin regarding the CL description. See > > > https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list... > for some general suggestions on CL descriptions. > > I have updated the description. I hope it is ok now. Almost, the one trick is that the Rietveld UI makes this a little funny: you need to duplicate the Subject field as the first line of your Description field (with a blank line between the first and the rest of the CL description). It's the Description alone that becomes the commit message in git.
Description was changed from ========== The latter was left from a previous commit and not updated later to reflect the new name. ========== to ========== [cleanup] #undef DECLARE_ERROR instead of non-existent DEFINE_ERROR The latter was left from a previous commit and not updated later to reflect the new name. ==========
On 2016/10/27 at 12:02:36, adamk wrote: > On 2016/10/27 11:58:46, hferreiro wrote: > > On 2016/10/26 at 14:30:45, adamk wrote: > > > CLA is all set, but agree with Caitlin regarding the CL description. See > > > > > https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list... > > for some general suggestions on CL descriptions. > > > > I have updated the description. I hope it is ok now. > > Almost, the one trick is that the Rietveld UI makes this a little funny: you need to duplicate the Subject field as the first line of your Description field (with a blank line between the first and the rest of the CL description). It's the Description alone that becomes the commit message in git. Ok, sorry about that.
lgtm, I know it's a bit of a pain to use this tool
The CQ bit was checked by henrique.ferreiro@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from caitp@igalia.com Link to the patchset: https://codereview.chromium.org/2447023004/#ps20001 (title: "[cleanup] #undef DECLARE_ERROR instead of non-existent DEFINE_ERROR")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
On 2016/10/27 12:36:18, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) Nicely done Henrique :) 👍
Message was sent while issue was closed.
Description was changed from ========== [cleanup] #undef DECLARE_ERROR instead of non-existent DEFINE_ERROR The latter was left from a previous commit and not updated later to reflect the new name. ========== to ========== [cleanup] #undef DECLARE_ERROR instead of non-existent DEFINE_ERROR The latter was left from a previous commit and not updated later to reflect the new name. Committed: https://crrev.com/2c38023be38ff4f78130879f589a8da6b6f619c6 Cr-Commit-Position: refs/heads/master@{#40620} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2c38023be38ff4f78130879f589a8da6b6f619c6 Cr-Commit-Position: refs/heads/master@{#40620} |
