Issue 2446993002: Internalize AstRawStrings by walking the string_table_ instead of adding them to a list

Issue 2446993002: Internalize AstRawStrings by walking the string_table_ instead of adding them to a list (Closed)

Created:
4 years, 1 month ago by Toon Verwaest

Modified:
4 years, 1 month ago

Reviewers:
adamk

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Internalize AstRawStrings by walking the string_table_ instead of adding them to a list BUG= Committed: https://crrev.com/9d5b307fa1d0219fcf0d6989dc16046a03321b71 Cr-Commit-Position: refs/heads/master@{#40561}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -25 lines)			Patch
	M	src/ast/ast-value-factory.h	View	1 2	7 chunks	+19 lines, -19 lines	0 comments	Download
	M	src/ast/ast-value-factory.cc	View	1 2	4 chunks	+14 lines, -6 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446993002/40001

4 years, 1 month ago (2016-10-25 11:10:59 UTC) #5

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:12:32 UTC) #8

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/9d5b307fa1d0219fcf0d6989dc16046a03321b71
Cr-Commit-Position: refs/heads/master@{#40561}