[ic] Support negative lookup on receiver in data handlers.

[ic] Support negative lookup on receiver in data handlers.

BUG=v8:5561
Committed: https://crrev.com/4da8a9c7c38c93a40c5e3a9c1d2d30e53fc3c2a8
Cr-Commit-Position: refs/heads/master@{#40565}

[Igor Sheludko, 2016-10-25 08:48:20]

Description was changed from

==========
[ic] Encode the requirement to perform a negative lookup on receiver into data
handlers.

BUG=v8:5561
==========

to

==========
[ic] Encode the requirement to perform a negative lookup on receiver into data
handlers.

BUG=v8:5561
==========

[Igor Sheludko, 2016-10-25 08:52:02]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-10-25 08:53:38]

Description was changed from

==========
[ic] Encode the requirement to perform a negative lookup on receiver into data
handlers.

BUG=v8:5561
==========

to

==========
[ic] Support negative lookups on receiver in data handlers.

BUG=v8:5561
==========

[Igor Sheludko, 2016-10-25 08:55:34]

Description was changed from

==========
[ic] Support negative lookups on receiver in data handlers.

BUG=v8:5561
==========

to

==========
[ic] Support negative lookup on receiver in data handlers.

BUG=v8:5561
==========

[Igor Sheludko, 2016-10-25 08:55:42]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 08:55:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-10-25 08:56:53]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-10-25 08:56:54]

PTAL

[commit-bot: I haz the power, 2016-10-25 09:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 09:21:07]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-10-25 11:45:06]

Patchset #2 (id:40001) has been deleted

[Jakob Kummerow, 2016-10-25 13:35:58]

lgtm

https://codereview.chromium.org/2446983002/diff/20001/src/ic/handler-configur...
File src/ic/handler-configuration.h (right):

https://codereview.chromium.org/2446983002/diff/20001/src/ic/handler-configur...
src/ic/handler-configuration.h:23: // Applicable to kForFields and kForConsants
kinds only when loading value
nit: kForConstants

https://codereview.chromium.org/2446983002/diff/20001/src/ic/handler-configur...
src/ic/handler-configuration.h:70: // check is
nit: line break

[Igor Sheludko, 2016-10-25 13:46:24]

https://codereview.chromium.org/2446983002/diff/20001/src/ic/handler-configur...
File src/ic/handler-configuration.h (right):

https://codereview.chromium.org/2446983002/diff/20001/src/ic/handler-configur...
src/ic/handler-configuration.h:23: // Applicable to kForFields and kForConsants
kinds only when loading value
On 2016/10/25 13:35:58, Jakob Kummerow wrote:
> nit: kForConstants

Done.

https://codereview.chromium.org/2446983002/diff/20001/src/ic/handler-configur...
src/ic/handler-configuration.h:70: // check is
On 2016/10/25 13:35:58, Jakob Kummerow wrote:
> nit: line break

Done.

[Igor Sheludko, 2016-10-25 13:46:28]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-10-25 13:46:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2446983002/#ps60001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-10-25 13:46:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 14:29:10]

Description was changed from

==========
[ic] Support negative lookup on receiver in data handlers.

BUG=v8:5561
==========

to

==========
[ic] Support negative lookup on receiver in data handlers.

BUG=v8:5561
==========

[commit-bot: I haz the power, 2016-10-25 14:29:11]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:12:43]

Description was changed from

==========
[ic] Support negative lookup on receiver in data handlers.

BUG=v8:5561
==========

to

==========
[ic] Support negative lookup on receiver in data handlers.

BUG=v8:5561

Committed: https://crrev.com/4da8a9c7c38c93a40c5e3a9c1d2d30e53fc3c2a8
Cr-Commit-Position: refs/heads/master@{#40565}
==========

[commit-bot: I haz the power, 2016-11-17 22:12:44]

Patchset 2 (id:??) landed as
https://crrev.com/4da8a9c7c38c93a40c5e3a9c1d2d30e53fc3c2a8
Cr-Commit-Position: refs/heads/master@{#40565}