Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2446923003: Add test for warning-conditions around switch cases. (Closed)

Created:
4 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
4 years, 1 month ago
Reviewers:
eernst
CC:
reviews_dartlang.org, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test for warning-conditions around switch cases. Only tested on analyzer. R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/1d4657f3d42a1d3582880d1ae8ce989d57df3910

Patch Set 1 #

Patch Set 2 : Include test file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -0 lines) Patch
M tests/language/language_analyzer2.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/language/switch_case_warn_test.dart View 1 1 chunk +201 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-10-25 12:33:08 UTC) #2
eernst
lgtm
4 years, 1 month ago (2016-10-25 23:08:43 UTC) #4
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-10-26 07:03:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1d4657f3d42a1d3582880d1ae8ce989d57df3910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698