Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2446923002: bindings: Drop |idl_name| from IdlDefinitions (Closed)

Created:
4 years, 1 month ago by bashi
Modified:
4 years, 1 month ago
Reviewers:
haraken, peria, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Drop |idl_name| from IdlDefinitions |idl_name| comes from filename but it's a bad idea to control code generation by using filename. Fortunately we no longer use it, so let's remove it. BUG=658098 Committed: https://crrev.com/310f96a12cbf42ca7e29148970d35f75221e0e87 Cr-Commit-Position: refs/heads/master@{#427281}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -90 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_definitions.py View 39 chunks +72 lines, -87 lines 1 comment Download
M third_party/WebKit/Source/bindings/scripts/idl_reader.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bashi
PTAL https://codereview.chromium.org/2446923002/diff/1/third_party/WebKit/Source/bindings/scripts/idl_definitions.py File third_party/WebKit/Source/bindings/scripts/idl_definitions.py (left): https://codereview.chromium.org/2446923002/diff/1/third_party/WebKit/Source/bindings/scripts/idl_definitions.py#oldcode260 third_party/WebKit/Source/bindings/scripts/idl_definitions.py:260: # FIXME: remove, just treat enums as a ...
4 years, 1 month ago (2016-10-25 02:09:31 UTC) #4
peria
lgtm
4 years, 1 month ago (2016-10-25 04:30:14 UTC) #7
haraken
LGTM
4 years, 1 month ago (2016-10-25 05:03:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446923002/1
4 years, 1 month ago (2016-10-25 05:17:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 05:22:23 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/310f96a12cbf42ca7e29148970d35f75221e0e87 Cr-Commit-Position: refs/heads/master@{#427281}
4 years, 1 month ago (2016-10-25 05:26:03 UTC) #13
Yuki
4 years, 1 month ago (2016-10-25 07:55:25 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698