Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2446903003: Properly initialize GuestViewManager.factory in ProcessManagerBrowserTest. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly initialize GuestViewManager.factory in ProcessManagerBrowserTest. BUG=658955 Committed: https://crrev.com/af85e4c4da6412c77645ff539069eb165361b395 Cr-Commit-Position: refs/heads/master@{#427406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/extensions/process_manager_browsertest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
krasin1
4 years, 1 month ago (2016-10-25 03:32:11 UTC) #3
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-10-25 17:43:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446903003/1
4 years, 1 month ago (2016-10-25 17:47:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 17:54:54 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 18:03:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af85e4c4da6412c77645ff539069eb165361b395
Cr-Commit-Position: refs/heads/master@{#427406}

Powered by Google App Engine
This is Rietveld 408576698