Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

ui/views/touchui/touch_selection_controller_impl.cc

Index: ui/views/touchui/touch_selection_controller_impl.cc
diff --git a/ui/views/touchui/touch_selection_controller_impl.cc b/ui/views/touchui/touch_selection_controller_impl.cc
index 89f6bdcafa8799b209e8bf96536c634a16c0737c..1e69f6dc9f1d36a779f4d7c63a03b0049651bc6d 100644
--- a/ui/views/touchui/touch_selection_controller_impl.cc
+++ b/ui/views/touchui/touch_selection_controller_impl.cc
@@ -422,8 +422,8 @@ void TouchSelectionControllerImpl::ExecuteCommand(int command_id,
 
 void TouchSelectionControllerImpl::OpenContextMenu() {
   // Context menu should appear centered on top of the selected region.
-  gfx::Point anchor(context_menu_->anchor_rect().CenterPoint().x(),
-                    context_menu_->anchor_rect().y());
+  const gfx::Rect& rect = context_menu_->GetAnchorRect();

[msw, 2013/09/27 21:21:53]

I don't think using a ref is correct here, since the function isn't return a
const ref to a class member (though I guess it could do that...).

[Mr4D (OOO till 08-26), 2013/09/27 22:52:21]

Done.

+  gfx::Point anchor(rect.CenterPoint().x(), rect.y());

[msw, 2013/09/27 21:21:53]

nit: const

[Mr4D (OOO till 08-26), 2013/09/27 22:52:21]

Done.

   HideContextMenu();
   client_view_->OpenContextMenu(anchor);
 }