chrome/browser/ui/views/location_bar/zoom_bubble_view.cc - Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed unit test Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc » ('j') | ui/views/bubble/bubble_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

index f3d61a3f7aac0876c9b40db95cdcb74605bb8f62..aabb77a497840c4cce3e6fcc1b981fe1729b92e1 100644

--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

@@ -56,7 +56,7 @@ void ZoomBubbleView::ShowBubble(content::WebContents* web_contents,

// is equal to |auto_close|, the bubble can be reused and only the label text

// needs to be updated.

if (zoom_bubble_ &&

- zoom_bubble_->anchor_view() == anchor_view &&

+ zoom_bubble_->GetAnchorView() == anchor_view &&

zoom_bubble_->auto_close_ == auto_close) {

zoom_bubble_->Refresh();

} else {

@@ -135,7 +135,7 @@ ZoomBubbleView::~ZoomBubbleView() {

}

void ZoomBubbleView::AdjustForFullscreen(const gfx::Rect& screen_bounds) {

- if (anchor_view())

+ if (GetAnchorView())

return;

// TODO(dbeam): should RTL logic be done in views::BubbleDelegateView?