Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: ui/views/touchui/touch_selection_controller_impl.cc

Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: A self check encountered a few things.. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/touchui/touch_selection_controller_impl.cc
diff --git a/ui/views/touchui/touch_selection_controller_impl.cc b/ui/views/touchui/touch_selection_controller_impl.cc
index 89f6bdcafa8799b209e8bf96536c634a16c0737c..90af930f0147c8a6f697969c6b511bcb6a25e123 100644
--- a/ui/views/touchui/touch_selection_controller_impl.cc
+++ b/ui/views/touchui/touch_selection_controller_impl.cc
@@ -422,8 +422,8 @@ void TouchSelectionControllerImpl::ExecuteCommand(int command_id,
void TouchSelectionControllerImpl::OpenContextMenu() {
// Context menu should appear centered on top of the selected region.
- gfx::Point anchor(context_menu_->anchor_rect().CenterPoint().x(),
- context_menu_->anchor_rect().y());
+ gfx::Point anchor(context_menu_->AnchorRect().CenterPoint().x(),
msw 2013/09/27 18:20:31 nit: cache the anchor rect in a local beforehand.
Mr4D (OOO till 08-26) 2013/09/27 20:29:35 Done.
+ context_menu_->AnchorRect().y());
HideContextMenu();
client_view_->OpenContextMenu(anchor);
}
« ui/views/bubble/bubble_delegate_unittest.cc ('K') | « ui/views/touchui/touch_editing_menu.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698