Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"
 
 #include <set>
 #include <vector>
 
 #include "ash/ash_switches.h"
@@ skipping 568 matching lines @@
       // ui::SHOW_STATE_MINIMIZED.
       LayoutBrowserRootView();
     }
   }
 }
 
 void ImmersiveModeControllerAsh::OnAddTransientChild(aura::Window* window,
                                                      aura::Window* transient) {
   views::BubbleDelegateView* bubble_delegate = AsBubbleDelegate(transient);
   if (bubble_delegate &&
-      bubble_delegate->anchor_view() &&
-      top_container_->Contains(bubble_delegate->anchor_view())) {
+      bubble_delegate->GetAnchorView() &&
+      top_container_->Contains(bubble_delegate->GetAnchorView())) {
     // Observe the aura::Window because the BubbleDelegateView may not be
     // parented to the widget's root view yet so |bubble_delegate->GetWidget()|
     // may still return NULL.
     bubble_manager_->StartObserving(transient);
   }
 }
 
 void ImmersiveModeControllerAsh::OnRemoveTransientChild(
     aura::Window* window,
     aura::Window* transient) {
@@ skipping 229 matching lines @@
       views::Widget::GetWidgetForNativeWindow(native_window_);
   if (widget->IsActive()) {
     views::View* focused_view = widget->GetFocusManager()->GetFocusedView();
     if (top_container_->Contains(focused_view))
       hold_lock = true;
   } else {
     aura::Window* active_window = aura::client::GetActivationClient(
         native_window_->GetRootWindow())->GetActiveWindow();
     views::BubbleDelegateView* bubble_delegate =
         AsBubbleDelegate(active_window);
-    if (bubble_delegate && bubble_delegate->anchor_view()) {
+    if (bubble_delegate && bubble_delegate->anchor_widget()) {
       // BubbleManager will already have locked the top-of-window views if the
       // bubble is anchored to a child of |top_container_|. Don't acquire
       // |focus_revealed_lock_| here for the sake of simplicity.
+      // Note: Instead of checking for the existence of the |anchor_view|,
+      // the existence of the |anchor_widget| is performed to avoid the case
+      // where the view is already gone (and the widget is still running).
     } else {
       // The currently active window is not |native_window_| and it is not a
       // bubble with an anchor view. The top-of-window views should be revealed
       // if:
       // 1) The active window is a transient child of |native_window_|.
       // 2) The top-of-window views are already revealed. This restriction
       //    prevents a transient window opened by the web contents while the
       //    top-of-window views are hidden from from initiating a reveal.
       // The top-of-window views will stay revealed till |native_window_| is
       // reactivated.
@@ skipping 309 matching lines @@
 
 void ImmersiveModeControllerAsh::RecreateBubbleManager() {
   bubble_manager_.reset(new BubbleManager(this));
   const std::vector<aura::Window*> transient_children =
       native_window_->transient_children();
   for (size_t i = 0; i < transient_children.size(); ++i) {
     aura::Window* transient_child = transient_children[i];
     views::BubbleDelegateView* bubble_delegate =
         AsBubbleDelegate(transient_child);
     if (bubble_delegate &&
-        bubble_delegate->anchor_view() &&
-        top_container_->Contains(bubble_delegate->anchor_view())) {
+        bubble_delegate->GetAnchorView() &&
+        top_container_->Contains(bubble_delegate->GetAnchorView())) {
       bubble_manager_->StartObserving(transient_child);
     }
   }
 }