Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/extension_installed_bubble_view.h" 5 #include "chrome/browser/ui/views/extensions/extension_installed_bubble_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 553 matching lines...) Expand 10 before | Expand all | Expand 10 after
564 DCHECK(reference_view); 564 DCHECK(reference_view);
565 } else if (bubble_.type() == bubble_.OMNIBOX_KEYWORD) { 565 } else if (bubble_.type() == bubble_.OMNIBOX_KEYWORD) {
566 LocationBarView* location_bar_view = browser_view->GetLocationBarView(); 566 LocationBarView* location_bar_view = browser_view->GetLocationBarView();
567 reference_view = location_bar_view; 567 reference_view = location_bar_view;
568 DCHECK(reference_view); 568 DCHECK(reference_view);
569 } 569 }
570 570
571 // Default case. 571 // Default case.
572 if (reference_view == NULL) 572 if (reference_view == NULL)
573 reference_view = browser_view->GetToolbarView()->app_menu(); 573 reference_view = browser_view->GetToolbarView()->app_menu();
574 set_anchor_view(reference_view); 574 SetAnchorView(reference_view);
575 575
576 set_arrow(bubble_.type() == bubble_.OMNIBOX_KEYWORD ? 576 set_arrow(bubble_.type() == bubble_.OMNIBOX_KEYWORD ?
577 views::BubbleBorder::TOP_LEFT : 577 views::BubbleBorder::TOP_LEFT :
578 views::BubbleBorder::TOP_RIGHT); 578 views::BubbleBorder::TOP_RIGHT);
579 SetLayoutManager(new views::FillLayout()); 579 SetLayoutManager(new views::FillLayout());
580 AddChildView(new InstalledBubbleContent( 580 AddChildView(new InstalledBubbleContent(
581 bubble_.browser(), bubble_.extension(), bubble_.type(), 581 bubble_.browser(), bubble_.extension(), bubble_.type(),
582 &bubble_.icon(), this)); 582 &bubble_.icon(), this));
583 583
584 views::BubbleDelegateView::CreateBubble(this); 584 views::BubbleDelegateView::CreateBubble(this);
(...skipping 22 matching lines...) Expand all
607 void ExtensionInstalledBubbleView::WindowClosing() { 607 void ExtensionInstalledBubbleView::WindowClosing() {
608 if (bubble_.extension() && bubble_.type() == bubble_.PAGE_ACTION) { 608 if (bubble_.extension() && bubble_.type() == bubble_.PAGE_ACTION) {
609 BrowserView* browser_view = 609 BrowserView* browser_view =
610 BrowserView::GetBrowserViewForBrowser(bubble_.browser()); 610 BrowserView::GetBrowserViewForBrowser(bubble_.browser());
611 browser_view->GetLocationBarView()->SetPreviewEnabledPageAction( 611 browser_view->GetLocationBarView()->SetPreviewEnabledPageAction(
612 extensions::ExtensionActionManager::Get(bubble_.browser()->profile())-> 612 extensions::ExtensionActionManager::Get(bubble_.browser()->profile())->
613 GetPageAction(*bubble_.extension()), 613 GetPageAction(*bubble_.extension()),
614 false); // preview_enabled 614 false); // preview_enabled
615 } 615 }
616 } 616 }
OLDNEW
« no previous file with comments | « ash/wm/caption_buttons/maximize_bubble_controller.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698