chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h - Issue 2446893008: NetworkHandler: Add ui_proxy_config_service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

Issue 2446893008: NetworkHandler: Add ui_proxy_config_service (Closed)

Patch Set: Feedback + elim bogus shill errors Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_pref_state_observer_unittest.cc ('K') | « chrome/browser/chromeos/proxy_cros_settings_parser.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | chromeos/network/network_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

index 5bbb4fda89f5ef4efd2cab67809040d3226ab0b5..cd078c1828ae74f655a4c7dd049cc3300c855b8d 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

@@ -11,7 +11,6 @@

#include "base/memory/linked_ptr.h"

#include "chrome/browser/chromeos/settings/cros_settings.h"

#include "chrome/browser/ui/webui/options/core_options_handler.h"

-#include "chromeos/network/proxy/ui_proxy_config_service.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

@@ -68,7 +67,8 @@ class CoreChromeOSOptionsHandler : public ::options::CoreOptionsHandler,

content::NotificationRegistrar notification_registrar_;

- UIProxyConfigService proxy_config_service_;

+ // Currently selected network id.

+ std::string network_guid_;

James Cook 2016/11/02 01:57:33 #include <string> for new usage of string

stevenjb 2016/11/02 18:03:41 Done.

};

James Cook 2016/11/02 01:57:33 DISALLOW_COPY_AND_ASSIGN while you're here

stevenjb 2016/11/02 18:03:41 Done.

} // namespace options