Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2446893004: [ObjC ARC] Converts ios/web/shell/test to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
baxley
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web/shell/test to ARC. Notable changes:none BUG=624365 Committed: https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832 Cr-Commit-Position: refs/heads/master@{#427731}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M ios/web/shell/test/BUILD.gn View 1 chunk +2 lines, -0 lines 3 comments Download
M ios/web/shell/test/app/navigation_test_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/test/app/web_shell_test_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/test/app/web_view_interaction_test_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_actions.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_base_test_case.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_earl_grey.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_matchers.mm View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
stkhapugin
ptal
4 years, 1 month ago (2016-10-25 16:11:08 UTC) #6
baxley
One question about files in ios/web/shell/test (and not subdirectories) https://codereview.chromium.org/2446893004/diff/1/ios/web/shell/test/BUILD.gn File ios/web/shell/test/BUILD.gn (right): https://codereview.chromium.org/2446893004/diff/1/ios/web/shell/test/BUILD.gn#newcode14 ios/web/shell/test/BUILD.gn:14: ...
4 years, 1 month ago (2016-10-25 16:16:29 UTC) #7
stkhapugin
https://codereview.chromium.org/2446893004/diff/1/ios/web/shell/test/BUILD.gn File ios/web/shell/test/BUILD.gn (right): https://codereview.chromium.org/2446893004/diff/1/ios/web/shell/test/BUILD.gn#newcode14 ios/web/shell/test/BUILD.gn:14: "pdf_egtest.mm", On 2016/10/25 16:16:29, baxley wrote: > Will you ...
4 years, 1 month ago (2016-10-26 15:51:19 UTC) #8
baxley
On 2016/10/26 15:51:19, stkhapugin wrote: > https://codereview.chromium.org/2446893004/diff/1/ios/web/shell/test/BUILD.gn > File ios/web/shell/test/BUILD.gn (right): > > https://codereview.chromium.org/2446893004/diff/1/ios/web/shell/test/BUILD.gn#newcode14 > ...
4 years, 1 month ago (2016-10-26 16:04:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446893004/1
4 years, 1 month ago (2016-10-26 16:18:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 17:30:52 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:50:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832
Cr-Commit-Position: refs/heads/master@{#427731}

Powered by Google App Engine
This is Rietveld 408576698