Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2446893003: Make Quic client more memory efficient. Protected by --quic_headers_stream_release_sequencer_buffer. (Closed)

Created:
4 years, 1 month ago by danzh1
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Quic client more memory efficient. Protected by --quic_headers_stream_release_sequencer_buffer. Release Quic client headers stream's sequencer buffer memory if no active request is going on. Merge internal change: 136071184 R=rch@chromium.org BUG=635041 Committed: https://crrev.com/34c70a32d562e8205bad739b94c28f1e4d387a15 Cr-Commit-Position: refs/heads/master@{#427514}

Patch Set 1 #

Patch Set 2 : Remove NOLINT #

Total comments: 1

Patch Set 3 : flip flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M net/quic/core/quic_client_session_base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_client_session_base.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 3 chunks +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
danzh1
4 years, 1 month ago (2016-10-25 14:17:12 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/2446893003/diff/20001/net/quic/core/quic_flags_list.h File net/quic/core/quic_flags_list.h (right): https://codereview.chromium.org/2446893003/diff/20001/net/quic/core/quic_flags_list.h#newcode161 net/quic/core/quic_flags_list.h:161: QUIC_FLAG(bool, FLAGS_quic_headers_stream_release_sequencer_buffer, false) Did you want this to ...
4 years, 1 month ago (2016-10-25 21:34:03 UTC) #6
danzh1
On 2016/10/25 21:34:03, Ryan Hamilton wrote: > lgtm > > https://codereview.chromium.org/2446893003/diff/20001/net/quic/core/quic_flags_list.h > File net/quic/core/quic_flags_list.h (right): ...
4 years, 1 month ago (2016-10-25 22:21:57 UTC) #7
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-10-25 22:31:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446893003/20001
4 years, 1 month ago (2016-10-25 22:32:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 22:38:53 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 22:41:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34c70a32d562e8205bad739b94c28f1e4d387a15
Cr-Commit-Position: refs/heads/master@{#427514}

Powered by Google App Engine
This is Rietveld 408576698