Revert of Add threadsafe version of PermissionManager::GetPermissionStatus

Revert of Add threadsafe version of PermissionManager::GetPermissionStatus (patchset #5 id:80001 of https://codereview.chromium.org/2439673004/ )

Reason for revert:
Going to address a number of issues that Raymes pointed out including:

1) It's unclear the purpose the overloaded GetPermissionStatus function (see https://google.github.io/styleguide/cppguide.html#Function_Overloading). It could be good to name it something that reflects its usage from a background thread.

2) In PermissionManager, it's unclear that it is threadsafe while the rest of the class isn't - we should add a comment.

3) It's unclear why HostContentSettingsMap needs to be passed in - it's already available in the PermissionContextBase.

4) I feel like it would be better to leave the default implementation empty in the PermissionContextBase and have NOTREACHED. Then if someone really wants to support querying a permission safely from a background thread, they have to think about it.

Original issue's description:
> Add threadsafe version of PermissionManager::GetPermissionStatus
>
> Add a version of GetPermissionStatus that takes a host_content_settings_map.
> This method is guaranteed to be threadsafe.
>
> BUG=658020
>
> R=jochen, mlamouri
>
> Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
> Cr-Commit-Position: refs/heads/master@{#427078}

TBR=mlamouri@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658020
Committed: https://crrev.com/c7d2c5a9df56e9a3a2cacc23fcb07ae93870d7b6
Cr-Commit-Position: refs/heads/master@{#427189}

[dougt, 2016-10-25 00:06:38]

The CQ bit was checked by dougt@chromium.org

[dougt, 2016-10-25 00:06:38]

Created Revert of Add threadsafe version of
PermissionManager::GetPermissionStatus

[commit-bot: I haz the power, 2016-10-25 00:07:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:07:34]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[raymes, 2016-10-25 00:30:35]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:31:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:31:16]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[raymes, 2016-10-25 00:33:58]

lgtm

[raymes, 2016-10-25 00:34:08]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:34:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:36:36]

Description was changed from

==========
Revert of Add threadsafe version of PermissionManager::GetPermissionStatus
(patchset #5 id:80001 of https://codereview.chromium.org/2439673004/ )

Reason for revert:
Going to address a number of issues that Raymes pointed out including:

1) It's unclear the purpose the overloaded GetPermissionStatus function (see
https://google.github.io/styleguide/cppguide.html#Function_Overloading). It
could be good to name it something that reflects its usage from a background
thread.

2) In PermissionManager, it's unclear that it is threadsafe while the rest of
the class isn't - we should add a comment.

3) It's unclear why HostContentSettingsMap needs to be passed in - it's already
available in the PermissionContextBase.

4) I feel like it would be better to leave the default implementation empty in
the PermissionContextBase and have NOTREACHED. Then if someone really wants to
support querying a permission safely from a background thread, they have to
think about it.



Original issue's description:
> Add threadsafe version of PermissionManager::GetPermissionStatus
> 
> Add a version of GetPermissionStatus that takes a host_content_settings_map.
> This method is guaranteed to be threadsafe.
> 
> BUG=658020
> 
> R=jochen, mlamouri
> 
> Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
> Cr-Commit-Position: refs/heads/master@{#427078}

TBR=mlamouri@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658020
==========

to

==========
Revert of Add threadsafe version of PermissionManager::GetPermissionStatus
(patchset #5 id:80001 of https://codereview.chromium.org/2439673004/ )

Reason for revert:
Going to address a number of issues that Raymes pointed out including:

1) It's unclear the purpose the overloaded GetPermissionStatus function (see
https://google.github.io/styleguide/cppguide.html#Function_Overloading). It
could be good to name it something that reflects its usage from a background
thread.

2) In PermissionManager, it's unclear that it is threadsafe while the rest of
the class isn't - we should add a comment.

3) It's unclear why HostContentSettingsMap needs to be passed in - it's already
available in the PermissionContextBase.

4) I feel like it would be better to leave the default implementation empty in
the PermissionContextBase and have NOTREACHED. Then if someone really wants to
support querying a permission safely from a background thread, they have to
think about it.



Original issue's description:
> Add threadsafe version of PermissionManager::GetPermissionStatus
> 
> Add a version of GetPermissionStatus that takes a host_content_settings_map.
> This method is guaranteed to be threadsafe.
> 
> BUG=658020
> 
> R=jochen, mlamouri
> 
> Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
> Cr-Commit-Position: refs/heads/master@{#427078}

TBR=mlamouri@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658020
==========

[commit-bot: I haz the power, 2016-10-25 00:36:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 00:40:39]

Description was changed from

==========
Revert of Add threadsafe version of PermissionManager::GetPermissionStatus
(patchset #5 id:80001 of https://codereview.chromium.org/2439673004/ )

Reason for revert:
Going to address a number of issues that Raymes pointed out including:

1) It's unclear the purpose the overloaded GetPermissionStatus function (see
https://google.github.io/styleguide/cppguide.html#Function_Overloading). It
could be good to name it something that reflects its usage from a background
thread.

2) In PermissionManager, it's unclear that it is threadsafe while the rest of
the class isn't - we should add a comment.

3) It's unclear why HostContentSettingsMap needs to be passed in - it's already
available in the PermissionContextBase.

4) I feel like it would be better to leave the default implementation empty in
the PermissionContextBase and have NOTREACHED. Then if someone really wants to
support querying a permission safely from a background thread, they have to
think about it.



Original issue's description:
> Add threadsafe version of PermissionManager::GetPermissionStatus
> 
> Add a version of GetPermissionStatus that takes a host_content_settings_map.
> This method is guaranteed to be threadsafe.
> 
> BUG=658020
> 
> R=jochen, mlamouri
> 
> Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
> Cr-Commit-Position: refs/heads/master@{#427078}

TBR=mlamouri@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658020
==========

to

==========
Revert of Add threadsafe version of PermissionManager::GetPermissionStatus
(patchset #5 id:80001 of https://codereview.chromium.org/2439673004/ )

Reason for revert:
Going to address a number of issues that Raymes pointed out including:

1) It's unclear the purpose the overloaded GetPermissionStatus function (see
https://google.github.io/styleguide/cppguide.html#Function_Overloading). It
could be good to name it something that reflects its usage from a background
thread.

2) In PermissionManager, it's unclear that it is threadsafe while the rest of
the class isn't - we should add a comment.

3) It's unclear why HostContentSettingsMap needs to be passed in - it's already
available in the PermissionContextBase.

4) I feel like it would be better to leave the default implementation empty in
the PermissionContextBase and have NOTREACHED. Then if someone really wants to
support querying a permission safely from a background thread, they have to
think about it.

Original issue's description:
> Add threadsafe version of PermissionManager::GetPermissionStatus
>
> Add a version of GetPermissionStatus that takes a host_content_settings_map.
> This method is guaranteed to be threadsafe.
>
> BUG=658020
>
> R=jochen, mlamouri
>
> Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
> Cr-Commit-Position: refs/heads/master@{#427078}

TBR=mlamouri@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658020

Committed: https://crrev.com/c7d2c5a9df56e9a3a2cacc23fcb07ae93870d7b6
Cr-Commit-Position: refs/heads/master@{#427189}
==========

[commit-bot: I haz the power, 2016-10-25 00:40:40]

Patchset 1 (id:??) landed as
https://crrev.com/c7d2c5a9df56e9a3a2cacc23fcb07ae93870d7b6
Cr-Commit-Position: refs/heads/master@{#427189}