chrome/browser/resources/bluetooth_internals/bluetooth_internals.html - Issue 2446823002: bluetooth: Componentize device list in chrome://bluetooth-internals.

Side by Side Diff: chrome/browser/resources/bluetooth_internals/bluetooth_internals.html

Issue 2446823002: bluetooth: Componentize device list in chrome://bluetooth-internals. (Closed)

Patch Set: Change innerText to textContent in device table Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/bluetooth_internals/adapter_broker.js ('K') | « chrome/browser/resources/bluetooth_internals/adapter_broker.js ('k') | chrome/browser/resources/bluetooth_internals/bluetooth_internals.js » ('j') | chrome/browser/resources/bluetooth_internals/device_collection.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3	3

4 <!-- TODO(crbug.com/658814): Localize strings. -->	4 <!-- TODO(crbug.com/658814): Localize strings. -->

5 <head>	5 <head>

6 <meta charset="utf-8">	6 <meta charset="utf-8">

7 <meta name="viewport" content="width=device-width, initial-scale=1">	7 <meta name="viewport" content="width=device-width, initial-scale=1">

8 <title>Bluetooth Internals</title>	8 <title>Bluetooth Internals</title>

9 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	9 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

10 <link rel="stylesheet" href="bluetooth_internals.css">	10 <link rel="stylesheet" href="bluetooth_internals.css">

	11 <link rel="import" href="chrome://resources/html/cr/ui.html">
	Dan Beam 2016/11/09 18:00:32 is there a reason you're importing just one of the is there a reason you're importing just one of these as an .html import? can we use that for all these <script>s or make new .html files if they don't exist? this is a good way to de-duplicate. followup note: this doesn't need to run on iOS, right? mbrunson 2016/11/10 01:02:13 It was mainly so others and myself know exactly wh Show quoted text On 2016/11/09 18:00:32, Dan Beam wrote: > is there a reason you're importing just one of these as an .html import? can we > use that for all these <script>s or make new .html files if they don't exist? > this is a good way to de-duplicate. > > followup note: this doesn't need to run on iOS, right? It was mainly so others and myself know exactly what I'm importing. It can change these to html imports though. It doesn't need to run on iOS as far as I know.
	12

11 <script src="chrome://resources/js/assert.js"></script>	13 <script src="chrome://resources/js/assert.js"></script>

	14 <script src="chrome://resources/js/cr/event_target.js"></script>

	15 <script src="chrome://resources/js/cr/ui/array_data_model.js"></script>

12 <script src="chrome://resources/js/util.js"></script>	16 <script src="chrome://resources/js/util.js"></script>

	17

	18 <script src="interfaces.js"></script>

	19 <script src="adapter_broker.js"></script>

	20 <script src="device_collection.js"></script>

	21 <script src="device_table.js"></script>

13 <script src="bluetooth_internals.js"></script>	22 <script src="bluetooth_internals.js"></script>

14 </head>	23 </head>

15	24

16 <body>	25 <body>

17 <header>	26 <header>

18 <div class="title">	27 <div class="title">

19 Bluetooth Internals	28 Bluetooth Internals

20 </div>	29 </div>

21 </header>	30 </header>

22 <table id="device-table">	31 </body>

	32

	33 <template id="table-template">

	34 <table>

23 <thead>	35 <thead>

24 <tr>	36 <tr>

25 <th>Name</th>	37 <th data-field="name_for_display">Name</th>

26 <th>Address</th>	38 <th data-field="address">Address</th>

27 <th>Latest RSSI</th>	39 <th data-field="rssi.value">Latest RSSI</th>

28 </tr>	40 </tr>

29 </thead>	41 </thead>

30 <tbody id="device-list">	42 <tbody class="table-body">

31 </tbody>	43 </tbody>

32 </table>	44 </table>

33 </body>

34

35 <template id="device-row-template">

36 <tr class="device-row">

37 <td class="device-name" data-label="Name"></td>

38 <td class="device-address" data-label="Address"></td>

39 <td class="device-rssi" data-label="Latest RSSI">Unknown</td>

40 </tr>

41 </template>	45 </template>

42	46

43 </html>	47 </html>

OLD	NEW