Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2446803004: Revert of Remove CFI blacklists entries for the fixed bug. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
pcc1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove CFI blacklists entries for the fixed bug. (patchset #1 id:1 of https://codereview.chromium.org/2445033002/ ) Reason for revert: Broke 'CFI Linux Full' bot: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/657/steps/blink_heap_unittests/logs/HeapTest.VectorDestructorsWithVtable Original issue's description: > Remove CFI blacklists entries for the fixed bug. > > BUG=568891 > > Committed: https://crrev.com/08f73f5e954340b0c0b5e29f75568ffdebb80588 > Cr-Commit-Position: refs/heads/master@{#427126} TBR=pcc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568891 Committed: https://crrev.com/1fd1f5a653e4bebfc481bd7233a5e5418b211ed3 Cr-Commit-Position: refs/heads/master@{#427168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/cfi/blacklist.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
krasin1
Created Revert of Remove CFI blacklists entries for the fixed bug.
4 years, 1 month ago (2016-10-24 22:14:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446803004/1
4 years, 1 month ago (2016-10-24 22:14:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 22:15:59 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 22:19:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd1f5a653e4bebfc481bd7233a5e5418b211ed3
Cr-Commit-Position: refs/heads/master@{#427168}

Powered by Google App Engine
This is Rietveld 408576698