Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2159)

Issue 2446803003: Actually compute AnalysisResult(s). (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Actually compute AnalysisResult(s). For now we don't have state transitioning and perform all work in a single loop. Later we will break the loop and wait for the "has work" stream after each operation. BTW, I don't like this stream approach, but I don't know yet anything better. The promise to produce the resolved CompilationUnit for every added file does not scale well for initial results. I want to weaken it to the promise that only priority and getResult() results get full content/unit. For all other files we need only errors, which can be cached. For index we need to use another apporach. I have a plan :-) R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4a5d98fa373621faf7353b39b7d596a3af77dbf4

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -68 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 8 chunks +60 lines, -68 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-10-24 22:04:10 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as 4a5d98fa373621faf7353b39b7d596a3af77dbf4 (presubmit successful).
4 years, 1 month ago (2016-10-25 16:49:19 UTC) #3
Brian Wilkerson
lgtm https://codereview.chromium.org/2446803003/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2446803003/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode209 pkg/analyzer/lib/src/dart/analysis/driver.dart:209: // TODO(scheglov) The loop is strange for now. ...
4 years, 1 month ago (2016-10-26 06:45:03 UTC) #4
Paul Berry
4 years, 1 month ago (2016-10-31 16:01:50 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698