Issue 2446803002: Bug fix: stop mirroring session when tab is closed. Fix bug caused by cl: https://codereview.chromi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2446803002: Bug fix: stop mirroring session when tab is closed. Fix bug caused by cl: https://codereview.chromi… (Closed)

Created:
4 years, 1 month ago by miu

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

Bug fix: stop mirroring session when tab is closed. Fix bug caused by cl: https://codereview.chromium.org/2365223002. |running_callback_| is used as a callback when status changes, and should not be reset if the capture is successfully started. BUG=655240 Review-Url: https://codereview.chromium.org/2408143004 Cr-Commit-Position: refs/heads/master@{#425124} (cherry picked from commit a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9)

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	content/renderer/media/media_stream_video_capturer_source.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

miu

4 years, 1 month ago (2016-10-24 21:53:37 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
d5045d332259b669cfd03baa23c28c33686fb651.

Expand Messages | Collapse Messages