Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2446723002: Permissions: Avoid poking at the heap after Blink shutdown (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Permissions: Avoid poking at the heap after Blink shutdown Changes serviceConnectionError() to be a no-op if Platform::current() is null. This can happen because MessageLoop destruction may invoke the callback after Blink shutdown. TBRing since this precise change was recommended by haraken@ and I'd like to make sure the fix lands ASAP. BUG=650637 TBR=haraken@chromium.org Committed: https://crrev.com/5d0e3432a52018d8134b5c7173a8b649a54ab90d Cr-Commit-Position: refs/heads/master@{#427190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446723002/1
4 years, 1 month ago (2016-10-24 20:43:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 00:39:08 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5d0e3432a52018d8134b5c7173a8b649a54ab90d Cr-Commit-Position: refs/heads/master@{#427190}
4 years, 1 month ago (2016-10-25 00:43:28 UTC) #9
haraken
4 years, 1 month ago (2016-10-25 05:14:21 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698