Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Issue 2446653002: Enable NTPSuggestionsSectionDismissal by default. (Closed)

Created:
4 years, 1 month ago by Michael van Ouwerkerk
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer, dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable NTPSuggestionsSectionDismissal by default. BUG=658647 Committed: https://crrev.com/3519ce15a26978e400845a53e7a09907873312a0 Cr-Commit-Position: refs/heads/master@{#427318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_snippets/features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael van Ouwerkerk
Nicolas, could you take a look please?
4 years, 1 month ago (2016-10-24 15:14:32 UTC) #4
Bernhard Bauer
lgtm, but under the assumption that the feature is indeed ready for (implementation) UI review.
4 years, 1 month ago (2016-10-24 15:15:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446653002/1
4 years, 1 month ago (2016-10-25 10:56:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 11:20:59 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3519ce15a26978e400845a53e7a09907873312a0 Cr-Commit-Position: refs/heads/master@{#427318}
4 years, 1 month ago (2016-10-25 11:22:32 UTC) #13
dgn
4 years, 1 month ago (2016-10-25 12:23:44 UTC) #14
Message was sent while issue was closed.
oops, sorry for the delay. lgtm

Powered by Google App Engine
This is Rietveld 408576698