PPAPI: Make GLES2 calls resilient to bad/dead resources.

ppapi/tests/test_graphics_3d.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_graphics_3d.h"
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ skipping 16 matching lines @@
   opengl_es2_ = static_cast<const PPB_OpenGLES2*>(
       pp::Module::Get()->GetBrowserInterface(PPB_OPENGLES2_INTERFACE));
   glInitializePPAPI(pp::Module::Get()->get_browser_interface());
   return opengl_es2_ && CheckTestingInterface();
 }
 
 void TestGraphics3D::RunTests(const std::string& filter) {
   RUN_CALLBACK_TEST(TestGraphics3D, FramePPAPI, filter);
   RUN_CALLBACK_TEST(TestGraphics3D, FrameGL, filter);
   RUN_CALLBACK_TEST(TestGraphics3D, ExtensionsGL, filter);
+  RUN_CALLBACK_TEST(TestGraphics3D, BadResource, filter);
 }
 
 std::string TestGraphics3D::TestFramePPAPI() {
   const int width = 16;
   const int height = 16;
   const int32_t attribs[] = {
       PP_GRAPHICS3DATTRIB_WIDTH, width,
       PP_GRAPHICS3DATTRIB_HEIGHT, height,
       PP_GRAPHICS3DATTRIB_NONE
   };
@@ skipping 113 matching lines @@
   GLubyte pixel_color[4];
   glReadPixels(x, y, 1, 1, GL_RGBA, GL_UNSIGNED_BYTE, pixel_color);
 
   ASSERT_EQ(pixel_color[0], expected_color[0]);
   ASSERT_EQ(pixel_color[1], expected_color[1]);
   ASSERT_EQ(pixel_color[2], expected_color[2]);
   ASSERT_EQ(pixel_color[3], expected_color[3]);
   PASS();
 }
 
+std::string TestGraphics3D::TestBadResource() {
+  // The point of this test is mostly just to make sure that we don't crash and
+  // provide reasonable (error) results when the resource is bad.
+  const PP_Resource kBadResource = 123;
+
+  // Access OpenGLES API through the PPAPI interface.
+  opengl_es2_->ClearColor(kBadResource, 0.0f, 0.0f, 0.0f, 0.0f);
+  opengl_es2_->Clear(kBadResource, GL_COLOR_BUFFER_BIT);
+  ASSERT_EQ(0, opengl_es2_->GetError(kBadResource));
+  ASSERT_EQ(NULL, opengl_es2_->GetString(kBadResource, GL_VERSION));
+  ASSERT_EQ(-1, opengl_es2_->GetUniformLocation(kBadResource, 0, NULL));
+  ASSERT_EQ(GL_FALSE, opengl_es2_->IsBuffer(kBadResource, 0));
+  ASSERT_EQ(0, opengl_es2_->CheckFramebufferStatus(kBadResource,
+                                                   GL_DRAW_FRAMEBUFFER));
+
+  glSetCurrentContextPPAPI(kBadResource);
+  glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
+  glClear(GL_COLOR_BUFFER_BIT);
+  ASSERT_EQ(0, glGetError());
+  ASSERT_EQ(NULL, glGetString(GL_VERSION));
+  ASSERT_EQ(-1, glGetUniformLocation(0, NULL));
+  ASSERT_EQ(GL_FALSE, glIsBuffer(0));
+  ASSERT_EQ(0, glCheckFramebufferStatus(GL_DRAW_FRAMEBUFFER));
+  glClearColor(1.0f, 1.0f, 1.0f, 1.0f);
+  glClear(GL_COLOR_BUFFER_BIT);
+
+  PASS();
+}
+