Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2446583003: Revert of Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcoder… (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcoder… (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2437873004/ ) Reason for revert: Canary crashes crbug.com/658718 Original issue's description: > Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428043002/ )" > > The performance regression in crbug.com/657776 was not caused by this CL. > > This reverts commit 4490a7601c81647a4fb93da94360f271eb172473. > > BUG= TBR=mlippautz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/59fb09564a81b30f1d37d68c5fa046e609e23927 Cr-Commit-Position: refs/heads/master@{#40539}

Patch Set 1 #

Patch Set 2 : fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -54 lines) Patch
M src/heap/incremental-marking.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 4 chunks +24 lines, -10 lines 0 comments Download
M src/heap/mark-compact.cc View 1 12 chunks +42 lines, -34 lines 0 comments Download
M src/heap/spaces.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
ulan
4 years, 1 month ago (2016-10-24 14:30:12 UTC) #2
Created Revert of Reland "[heap] Start sweeper tasks after evacuation. (patchset
#2 id:20001 of https://chromiumcoder…

Powered by Google App Engine
This is Rietveld 408576698