Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/ui/ash/web_dialog_util.h

Issue 2446573003: chromeos: Make "mobile network" and "set time" dialogs work with mash (Closed)
Patch Set: cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/web_dialog_util.h
diff --git a/chrome/browser/ui/ash/web_dialog_util.h b/chrome/browser/ui/ash/web_dialog_util.h
index d330997dd83d6aaeac1a0f04a43993a0e834cc84..fbfc6690b1df7298ca378099ac2186439cbb694a 100644
--- a/chrome/browser/ui/ash/web_dialog_util.h
+++ b/chrome/browser/ui/ash/web_dialog_util.h
@@ -17,15 +17,13 @@ class WebDialogDelegate;
namespace chrome {
-// Creates and shows an HTML dialog with the given delegate and context. The
-// dialog is created as a child of |parent|. If |parent| is null the dialog
-// will be placed in a fallback container window in the ash window hierarchy.
+// Creates and shows an HTML dialog with the given delegate and browser context.
+// The dialog is placed in the ash window hierarchy in the given container.
// See ash/public/cpp/shell_window_ids.h for |container_id| values. The window
// is destroyed when it is closed. See also chrome::ShowWebDialog().
-void ShowWebDialogWithContainer(gfx::NativeView parent,
- int container_id,
- content::BrowserContext* context,
- ui::WebDialogDelegate* delegate);
+void ShowWebDialogInContainer(int container_id,
msw 2016/10/24 22:18:09 q: Should this live alongside chrome::ShowWebDialo
James Cook 2016/10/25 00:29:04 Moved it next to chrome::ShowWebDialog().
+ content::BrowserContext* context,
+ ui::WebDialogDelegate* delegate);
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698