Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/chromeos/policy/android_management_client.cc

Issue 2446563002: Refactor ArcAndroidManagementChecker. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/policy/arc_android_management_checker_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/android_management_client.cc
diff --git a/chrome/browser/chromeos/policy/android_management_client.cc b/chrome/browser/chromeos/policy/android_management_client.cc
index 9f85a00c03797dad5a4a16c376de97ae187f6322..e68ab0055a0a903ee6e270051b5257570f27d788 100644
--- a/chrome/browser/chromeos/policy/android_management_client.cc
+++ b/chrome/browser/chromeos/policy/android_management_client.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
+#include "base/callback_helpers.h"
#include "base/guid.h"
#include "base/logging.h"
#include "components/policy/core/common/cloud/device_management_service.h"
@@ -54,11 +55,11 @@ void AndroidManagementClient::OnGetTokenFailure(
const OAuth2TokenService::Request* request,
const GoogleServiceAuthError& error) {
DCHECK_EQ(token_request_.get(), request);
+ DCHECK(!callback_.is_null());
token_request_.reset();
LOG(ERROR) << "Token request failed: " << error.ToString();
- callback_.Run(RESULT_ERROR);
- callback_.Reset();
+ base::ResetAndReturn(&callback_).Run(RESULT_ERROR);
}
void AndroidManagementClient::RequestAccessToken() {
@@ -90,6 +91,7 @@ void AndroidManagementClient::OnAndroidManagementChecked(
DeviceManagementStatus status,
int net_error,
const em::DeviceManagementResponse& response) {
+ DCHECK(!callback_.is_null());
if (status == DM_STATUS_SUCCESS &&
!response.has_check_android_management_response()) {
LOG(WARNING) << "Invalid check android management response.";
@@ -109,8 +111,7 @@ void AndroidManagementClient::OnAndroidManagementChecked(
}
request_job_.reset();
- callback_.Run(result);
- callback_.Reset();
+ base::ResetAndReturn(&callback_).Run(result);
}
} // namespace policy
« no previous file with comments | « chrome/browser/chromeos/arc/policy/arc_android_management_checker_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698