Support Service Worker NavigationPreload with PlzNavigate.

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 1122 matching lines @@
   AddFilter(message_port_message_filter_.get());
 
   scoped_refptr<CacheStorageDispatcherHost> cache_storage_filter =
       new CacheStorageDispatcherHost();
   cache_storage_filter->Init(storage_partition_impl_->GetCacheStorageContext());
   AddFilter(cache_storage_filter.get());
 
   scoped_refptr<ServiceWorkerDispatcherHost> service_worker_filter =
       new ServiceWorkerDispatcherHost(
           GetID(), message_port_message_filter_.get(), resource_context,
-          base::Bind(&RenderProcessHostImpl::CreateURLLoaderFactory,
-                     weak_factory_.GetWeakPtr()));
+          CreateURLLoaderFactoryGetter());
   service_worker_filter->Init(
       storage_partition_impl_->GetServiceWorkerContext());
   AddFilter(service_worker_filter.get());
 
   AddFilter(new SharedWorkerMessageFilter(
       GetID(), resource_context,
       WorkerStoragePartition(
           storage_partition_impl_->GetURLRequestContext(),
           storage_partition_impl_->GetMediaURLRequestContext(),
           storage_partition_impl_->GetAppCacheService(),
@@ skipping 247 matching lines @@
 }
 
 void RenderProcessHostImpl::PurgeAndSuspend() {
   Send(new ChildProcessMsg_PurgeAndSuspend());
 }
 
 mojom::Renderer* RenderProcessHostImpl::GetRendererInterface() {
   return renderer_interface_.get();
 }
 
+MojoURLLoaderFactoryGetter
+RenderProcessHostImpl::CreateURLLoaderFactoryGetter() {
+  return base::Bind(&RenderProcessHostImpl::CreateURLLoaderFactory,
+                    weak_factory_.GetWeakPtr());

[horo, 2016/10/31 14:50:32]

WeakPtr is not thread safe.
So we should not pass the MojoURLLoaderFactoryGetter to the IO thread.
http://www.chromium.org/developers/design-documents/threading#base_WeakPtr_an...

I will create another CL to avoid this problem.

Sorry for confusion.

[piman, 2016/10/31 20:43:25]

I'll wait for the update before a full review. Just one thing: if there are
specific expectations about the value returned from CreateURLLoaderFactoryGetter
(i.e. used on a different thread than where it's queried?), can you document
that in the API?

FYI, WeakPtr is not generally thread-safe, however it can be copied to other
threads - I don't know if that matters to you. The restriction is that it can
only be dereferenced  on the same thread as it gets cancelled (i.e. the thread
the WeakPtrFactory gets destroyed).

+}
+
 mojom::RouteProvider* RenderProcessHostImpl::GetRemoteRouteProvider() {
   return remote_route_provider_.get();
 }
 
 void RenderProcessHostImpl::AddRoute(int32_t routing_id,
                                      IPC::Listener* listener) {
   CHECK(!listeners_.Lookup(routing_id)) << "Found Routing ID Conflict: "
                                         << routing_id;
   listeners_.AddWithID(listener, routing_id);
 }
@@ skipping 1561 matching lines @@
   bad_message::ReceivedBadMessage(render_process_id,
                                   bad_message::RPH_MOJO_PROCESS_ERROR);
 }
 
 void RenderProcessHostImpl::CreateURLLoaderFactory(
     mojo::InterfaceRequest<mojom::URLLoaderFactory> request) {
   URLLoaderFactoryImpl::Create(resource_message_filter_, std::move(request));
 }
 
 }  // namespace content