Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: test/unittests/compiler/effect-control-linearizer-unittest.cc

Issue 2446543002: [turbofan] Support variable size argument popping in TF-generated functions (Closed)
Patch Set: Fix tests and arm64 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/effect-control-linearizer-unittest.cc
diff --git a/test/unittests/compiler/effect-control-linearizer-unittest.cc b/test/unittests/compiler/effect-control-linearizer-unittest.cc
index 0a12ea371a4a987491122b3917eaf73f98e4a88a..cc697734a9872253e7cf43a1c681bf37c2de9f66 100644
--- a/test/unittests/compiler/effect-control-linearizer-unittest.cc
+++ b/test/unittests/compiler/effect-control-linearizer-unittest.cc
@@ -60,7 +60,8 @@ TEST_F(EffectControlLinearizerTest, SimpleLoad) {
Node* load = graph()->NewNode(
simplified()->LoadField(AccessBuilder::ForHeapNumberValue()), heap_number,
graph()->start(), graph()->start());
- Node* ret = graph()->NewNode(common()->Return(), load, graph()->start(),
+ Node* zero = graph()->NewNode(common()->Int32Constant(0));
+ Node* ret = graph()->NewNode(common()->Return(), zero, load, graph()->start(),
graph()->start());
// Build the basic block structure.
@@ -105,8 +106,9 @@ TEST_F(EffectControlLinearizerTest, DiamondLoad) {
Node* phi = graph()->NewNode(
common()->Phi(MachineRepresentation::kFloat64, 2), vtrue, vfalse, merge);
+ Node* zero = graph()->NewNode(common()->Int32Constant(0));
Node* ret =
- graph()->NewNode(common()->Return(), phi, graph()->start(), merge);
+ graph()->NewNode(common()->Return(), zero, phi, graph()->start(), merge);
// Build the basic block structure.
BasicBlock* start = schedule.start();
@@ -206,8 +208,9 @@ TEST_F(EffectControlLinearizerTest, FloatingDiamondsControlWiring) {
Node* if_false2 = graph()->NewNode(common()->IfFalse(), branch2);
Node* merge2 = graph()->NewNode(common()->Merge(2), if_true2, if_false2);
- Node* ret =
- graph()->NewNode(common()->Return(), call, graph()->start(), if_success);
+ Node* zero = graph()->NewNode(common()->Int32Constant(0));
+ Node* ret = graph()->NewNode(common()->Return(), zero, call, graph()->start(),
+ if_success);
// Build the basic block structure.
BasicBlock* start = schedule.start();
@@ -289,7 +292,9 @@ TEST_F(EffectControlLinearizerTest, LoopLoad) {
simplified()->LoadField(AccessBuilder::ForHeapNumberValue()), heap_number,
graph()->start(), loop);
- Node* ret = graph()->NewNode(common()->Return(), load, effect_phi, if_true);
+ Node* zero = graph()->NewNode(common()->Int32Constant(0));
+ Node* ret =
+ graph()->NewNode(common()->Return(), zero, load, effect_phi, if_true);
// Build the basic block structure.
BasicBlock* start = schedule.start();
« no previous file with comments | « test/unittests/compiler/common-operator-unittest.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698