Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: src/compiler/common-operator.cc

Issue 2446543002: [turbofan] Support variable size argument popping in TF-generated functions (Closed)
Patch Set: Fix tests and arm64 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/code-generator.h ('k') | src/compiler/common-operator-reducer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/common-operator.cc
diff --git a/src/compiler/common-operator.cc b/src/compiler/common-operator.cc
index eb5ff7411c44295ae21256cec54d7f003d2ea203..12a06530e39fdc8a46b5fdbbe3f1659532e6c385 100644
--- a/src/compiler/common-operator.cc
+++ b/src/compiler/common-operator.cc
@@ -256,8 +256,8 @@ OsrGuardType OsrGuardTypeOf(Operator const* op) {
#define CACHED_RETURN_LIST(V) \
V(1) \
V(2) \
- V(3)
-
+ V(3) \
+ V(4)
#define CACHED_END_LIST(V) \
V(1) \
@@ -396,16 +396,16 @@ struct CommonOperatorGlobalCache final {
CACHED_END_LIST(CACHED_END)
#undef CACHED_END
- template <size_t kInputCount>
+ template <size_t kValueInputCount>
struct ReturnOperator final : public Operator {
ReturnOperator()
- : Operator( // --
- IrOpcode::kReturn, Operator::kNoThrow, // opcode
- "Return", // name
- kInputCount, 1, 1, 0, 0, 1) {} // counts
+ : Operator( // --
+ IrOpcode::kReturn, Operator::kNoThrow, // opcode
+ "Return", // name
+ kValueInputCount + 1, 1, 1, 0, 0, 1) {} // counts
};
-#define CACHED_RETURN(input_count) \
- ReturnOperator<input_count> kReturn##input_count##Operator;
+#define CACHED_RETURN(value_input_count) \
+ ReturnOperator<value_input_count> kReturn##value_input_count##Operator;
CACHED_RETURN_LIST(CACHED_RETURN)
#undef CACHED_RETURN
@@ -632,7 +632,6 @@ const Operator* CommonOperatorBuilder::End(size_t control_input_count) {
0, 0, control_input_count, 0, 0, 0); // counts
}
-
const Operator* CommonOperatorBuilder::Return(int value_input_count) {
switch (value_input_count) {
#define CACHED_RETURN(input_count) \
@@ -647,7 +646,7 @@ const Operator* CommonOperatorBuilder::Return(int value_input_count) {
return new (zone()) Operator( //--
IrOpcode::kReturn, Operator::kNoThrow, // opcode
"Return", // name
- value_input_count, 1, 1, 0, 0, 1); // counts
+ value_input_count + 1, 1, 1, 0, 0, 1); // counts
}
« no previous file with comments | « src/compiler/code-generator.h ('k') | src/compiler/common-operator-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698