 Chromium Code Reviews
 Chromium Code Reviews Issue 2446543002:
  [turbofan] Support variable size argument popping in TF-generated functions  (Closed)
    
  
    Issue 2446543002:
  [turbofan] Support variable size argument popping in TF-generated functions  (Closed) 
  | Index: src/compiler/bytecode-graph-builder.cc | 
| diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc | 
| index 93a2971ed16837801609c32d5dbed6aee2bc28bd..841010893262a610365c6ce1ae05fb23d51b1039 100644 | 
| --- a/src/compiler/bytecode-graph-builder.cc | 
| +++ b/src/compiler/bytecode-graph-builder.cc | 
| @@ -1727,8 +1727,9 @@ void BytecodeGraphBuilder::VisitStackCheck() { | 
| void BytecodeGraphBuilder::VisitReturn() { | 
| BuildLoopExitsForFunctionExit(); | 
| + Node* pop_node = graph()->NewNode(common()->Int32Constant(0)); | 
| 
Michael Starzinger
2016/10/28 14:12:14
nit: Likewise, please use jsgraph()->Int32Constant
 
danno
2016/10/31 10:06:39
Done.
 | 
| Node* control = | 
| - NewNode(common()->Return(), environment()->LookupAccumulator()); | 
| + NewNode(common()->Return(), pop_node, environment()->LookupAccumulator()); | 
| MergeControlToLeaveFunction(control); | 
| } |