Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3324)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 2446543002: [turbofan] Support variable size argument popping in TF-generated functions (Closed)
Patch Set: Fix bugs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 161a33a10d4ac8663c2e57e81b99a737b8468cfc..edac12ad8360d99898c01c464277328308b81539 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -3777,7 +3777,8 @@ Node* AstGraphBuilder::BuildReturn(Node* return_value) {
return_value =
NewNode(javascript()->CallRuntime(Runtime::kTraceExit), return_value);
}
- Node* control = NewNode(common()->Return(), return_value);
+ Node* pop_node = graph()->NewNode(common()->Int32Constant(0));
Michael Starzinger 2016/10/28 14:12:14 nit: Please use jsgraph()->Int32Constant(0) here.
danno 2016/10/31 10:06:39 Done.
+ Node* control = NewNode(common()->Return(), pop_node, return_value);
UpdateControlDependencyToLeaveFunction(control);
return control;
}

Powered by Google App Engine
This is Rietveld 408576698