src/compiler/js-inlining.cc - Issue 2446543002: [turbofan] Support variable size argument popping in TF-generated functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-inlining.cc

Issue 2446543002: [turbofan] Support variable size argument popping in TF-generated functions (Closed)

Patch Set: Fix x64 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-inlining.cc

diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc

index f9c28205341bf0985e860d5a99d4fb40ece28f8e..1a49e2f4c694164a75ec999427af904ade22d80d 100644

--- a/src/compiler/js-inlining.cc

+++ b/src/compiler/js-inlining.cc

@@ -184,7 +184,7 @@ Reduction JSInliner::InlineCall(Node* call, Node* new_target, Node* context,

for (Node* const input : end->inputs()) {

switch (input->opcode()) {

case IrOpcode::kReturn:

- values.push_back(NodeProperties::GetValueInput(input, 0));

+ values.push_back(NodeProperties::GetValueInput(input, 1));

effects.push_back(NodeProperties::GetEffectInput(input));

controls.push_back(NodeProperties::GetControlInput(input));

break;