src/compiler/bytecode-graph-builder.cc - Issue 2446543002: [turbofan] Support variable size argument popping in TF-generated functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 2446543002: [turbofan] Support variable size argument popping in TF-generated functions (Closed)

Patch Set: Fix x64 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 93a2971ed16837801609c32d5dbed6aee2bc28bd..841010893262a610365c6ce1ae05fb23d51b1039 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -1727,8 +1727,9 @@ void BytecodeGraphBuilder::VisitStackCheck() {

void BytecodeGraphBuilder::VisitReturn() {

BuildLoopExitsForFunctionExit();

+ Node* pop_node = graph()->NewNode(common()->Int32Constant(0));

Node* control =

- NewNode(common()->Return(), environment()->LookupAccumulator());

+ NewNode(common()->Return(), pop_node, environment()->LookupAccumulator());

MergeControlToLeaveFunction(control);

}