components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc - Issue 2446503002: Fix SubResourceFilter to work with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2446503002: Fix SubResourceFilter to work with PlzNavigate. (Closed)

Patch Set: fix unit tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/renderer/subresource_filter_agent.cc ('K') | « components/subresource_filter/content/renderer/subresource_filter_agent.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

index 9e3d181e7b8378b3dd3d54468d3d198d5fbccef2..12c51c73117cd542cfb70e461b1d1abe3a703e88 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

@@ -105,7 +105,8 @@ class SubresourceFilterAgentTest : public ::testing::Test {

void StartLoadAndSetActivationState(ActivationState activation_state) {

agent_as_rfo()->DidStartProvisionalLoad();

EXPECT_TRUE(agent_as_rfo()->OnMessageReceived(

- SubresourceFilterMsg_ActivateForProvisionalLoad(0, activation_state)));

+ SubresourceFilterMsg_ActivateForProvisionalLoad(0, activation_state,

+ GURL())));

agent_as_rfo()->DidCommitProvisionalLoad(

true /* is_new_navigation */, false /* is_same_page_navigation */);

}

@@ -232,7 +233,7 @@ TEST_F(SubresourceFilterAgentTest,

agent_as_rfo()->DidStartProvisionalLoad();

EXPECT_TRUE(agent_as_rfo()->OnMessageReceived(

SubresourceFilterMsg_ActivateForProvisionalLoad(

- 0, ActivationState::ENABLED)));

+ 0, ActivationState::ENABLED, GURL())));

agent_as_rfo()->DidStartProvisionalLoad();

agent_as_rfo()->DidCommitProvisionalLoad(true /* is_new_navigation */,

false /* is_same_page_navigation */);