Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2446503002: Fix SubResourceFilter to work with PlzNavigate. (Closed)
Patch Set: fix unit tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 7f1314ec93cde8ca33638da1f07d2e3bc0ccea2e..2f14b413aab09b3d0ac75d2bf9375e8cef40a535 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -139,8 +139,6 @@
#include "components/security_interstitials/core/ssl_error_ui.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "components/startup_metric_utils/browser/startup_metric_host_impl.h"
-#include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
-#include "components/subresource_filter/content/browser/subresource_filter_navigation_throttle.h"
#include "components/translate/core/common/translate_switches.h"
#include "components/url_formatter/url_fixer.h"
#include "components/variations/variations_associated_data.h"
@@ -3149,20 +3147,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
throttles.push_back(new extensions::ExtensionNavigationThrottle(handle));
#endif
- subresource_filter::ContentSubresourceFilterDriverFactory*
- subresource_filter_driver_factory =
- subresource_filter::ContentSubresourceFilterDriverFactory::
- FromWebContents(handle->GetWebContents());
- if (subresource_filter_driver_factory && handle->IsInMainFrame() &&
- handle->GetURL().SchemeIsHTTPOrHTTPS()) {
- // TODO(melandory): Activation logic should be moved to the
- // WebContentsObserver, once ReadyToCommitNavigation is available on
- // pre-PlzNavigate world (tracking bug: https://crbug.com/621856).
- throttles.push_back(
- subresource_filter::SubresourceFilterNavigationThrottle::Create(
- handle));
- }
-
return throttles;
}

Powered by Google App Engine
This is Rietveld 408576698