Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2446473002: GN: Fix build (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Fix build GN is unhappy when a rule that consumes a file generated by another rule doesn't depend directly on that rule. This change also quiets output from invoking Dart to follow the rule of GN builds that a successful build generates no output. Committed: https://github.com/dart-lang/sdk/commit/c39525802e8438509cea17e25f0081068208596c

Patch Set 1 #

Patch Set 2 : Remove redundant print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dart_for_gn.py View 1 1 chunk +13 lines, -2 lines 0 comments Download
M utils/compiler/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
zra
TBR
4 years, 2 months ago (2016-10-22 07:04:45 UTC) #3
zra
Committed patchset #2 (id:20001) manually as c39525802e8438509cea17e25f0081068208596c (presubmit successful).
4 years, 2 months ago (2016-10-22 07:05:45 UTC) #6
rmacnak
4 years, 1 month ago (2016-10-24 16:12:26 UTC) #7
Message was sent while issue was closed.
LGTM

I see that the bot's script uses gn --check but build.py doesn't pass --check.

Powered by Google App Engine
This is Rietveld 408576698