Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
TEST=trybot test

Committed: https://crrev.com/b3fd59ca9f44740cee6110dfde3ebd2c2f792ff5
Cr-Commit-Position: refs/heads/master@{#427273}

[Qiang(Joe) Xu, 2016-10-21 21:37:44]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 21:38:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2016-10-21 22:22:02]

Description was changed from

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

BUG=658390
==========

to

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
==========

[Qiang(Joe) Xu, 2016-10-21 22:22:02]

warx@chromium.org changed reviewers:
+ bartfab@chromium.org, derat@chromium.org, xiyuan@chromium.org

[Qiang(Joe) Xu, 2016-10-21 22:25:34]

Daniel/Bartosz for ash/ review

Xiyuan for webui/ review

Thanks!

[Daniel Erat, 2016-10-21 22:48:51]

lgtm

thanks!

https://codereview.chromium.org/2446453002/diff/1/ash/common/session/session_...
File ash/common/session/session_state_delegate.h (right):

https://codereview.chromium.org/2446453002/diff/1/ash/common/session/session_...
ash/common/session/session_state_delegate.h:68: // Returns true if the screen
should be locked automatically.
how about adding something like "... when the screen is turned off or the system
is suspended." at the end?

[Qiang(Joe) Xu, 2016-10-21 22:54:09]

Description was changed from

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
==========

to

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
TEST=trybot test
==========

[commit-bot: I haz the power, 2016-10-21 22:59:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:59:40]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2016-10-24 17:52:35]

warx@chromium.org changed reviewers:
+ stevenjb@chromium.org
- xiyuan@chromium.org

[Qiang(Joe) Xu, 2016-10-24 17:53:55]

Done for the comment.

Also replace xiyuan@ with stevenjb@ for
chrome/browser/ui/webui/options/chromeos/ dir owner review

Thanks!

https://codereview.chromium.org/2446453002/diff/1/ash/common/session/session_...
File ash/common/session/session_state_delegate.h (right):

https://codereview.chromium.org/2446453002/diff/1/ash/common/session/session_...
ash/common/session/session_state_delegate.h:68: // Returns true if the screen
should be locked automatically.
On 2016/10/21 22:48:51, Daniel Erat wrote:
> how about adding something like "... when the screen is turned off or the
system
> is suspended." at the end?

Done.

[stevenjb, 2016-10-24 18:00:06]

c/b/ui/webui/options lgtm

[Qiang(Joe) Xu, 2016-10-25 03:34:58]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2016-10-25 03:34:59]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2446453002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-10-25 03:35:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 04:06:52]

Description was changed from

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
TEST=trybot test
==========

to

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
TEST=trybot test
==========

[commit-bot: I haz the power, 2016-10-25 04:06:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 04:08:51]

Description was changed from

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
TEST=trybot test
==========

to

==========
Refactor ShouldLockScreenBeforeSuspending to ShouldLockScreenAutomatically

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
TEST=trybot test

Committed: https://crrev.com/b3fd59ca9f44740cee6110dfde3ebd2c2f792ff5
Cr-Commit-Position: refs/heads/master@{#427273}
==========

[commit-bot: I haz the power, 2016-10-25 04:08:52]

Patchset 2 (id:??) landed as
https://crrev.com/b3fd59ca9f44740cee6110dfde3ebd2c2f792ff5
Cr-Commit-Position: refs/heads/master@{#427273}