DescriptionMerge 262276 "Remove references to WebContentsView::SizeContents..."
> Remove references to WebContentsView::SizeContents from chrome/ and app/
>
> WebContentsView::SizeContents was initially introduced as a hack to allow the
> content module to resize a WebContentsView. This is odd because the embedder
> should be in full control of the layout of the WebContentsView. Unfortunately,
> SizeContents started being used as a platform-agnostic way for the embedder to
> change the size of a WebContentsView.
>
> The mac implementation of SizeContents has never been correct. The
> implementation would work correctly when SizeContents was used by the embedder,
> but it did not work when used by the content module. See
> https://code.google.com/p/chromium/issues/detail?id=264207 for details. I
> changed the mac implementation of SizeContents to be a no-op, which fixed the
> use of SizeContents from the content module, and broke its usage from the
> embedder.
>
> This CL introduces a new platform agnostic utility method to resize a
> WebContents. I've replaced all calls to SizeContents from chrome/ and app/ with
> a call to the new utility method. There is no expected behavioral change on
> aura, gtk, or android. This should fix the problems that have arisen from my
> change to the mac implementation of SizeContents.
>
> Ideally, the utility method would take a gfx::NativeView as its parameter.
> Unfortunately, I was unable perform the resizing on a ui::AndroidView*, and I
> was forced to pass in the whole WebContents to mimic the behavior of
> WebContentsViewAndroid::SizeContents.
>
> BUG=354769
> TEST=Follow steps listed in bug.
>
> Review URL: https://codereview.chromium.org/209023003
TBR=erikchen@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265022
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|