Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: base/test/opaque_ref_counted.cc

Issue 2446403006: Member initialization for scoped_refptr<T>::ptr_. (Closed)
Patch Set: remove extraneous TestOpaqueRefCounted calls Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/test/opaque_ref_counted.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/opaque_ref_counted.h" 5 #include "base/test/opaque_ref_counted.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace base { 10 namespace base {
11 11
12 class OpaqueRefCounted : public RefCounted<OpaqueRefCounted> { 12 class OpaqueRefCounted : public RefCounted<OpaqueRefCounted> {
13 public: 13 public:
14 OpaqueRefCounted() {} 14 OpaqueRefCounted() = default;
15 15
16 int Return42() { return 42; } 16 int Return42() { return 42; }
17 17
18 private: 18 private:
19 virtual ~OpaqueRefCounted() {} 19 friend class RefCounted<OpaqueRefCounted>;
20 ~OpaqueRefCounted() = default;
20 21
21 friend RefCounted<OpaqueRefCounted>;
22 DISALLOW_COPY_AND_ASSIGN(OpaqueRefCounted); 22 DISALLOW_COPY_AND_ASSIGN(OpaqueRefCounted);
23 }; 23 };
24 24
25 class OpaqueRefCountedThreadSafe
26 : public RefCounted<OpaqueRefCountedThreadSafe> {
27 public:
28 OpaqueRefCountedThreadSafe() = default;
29
30 int Return42() { return 42; }
31
32 private:
33 friend class RefCounted<OpaqueRefCountedThreadSafe>;
34 ~OpaqueRefCountedThreadSafe() = default;
35
36 DISALLOW_COPY_AND_ASSIGN(OpaqueRefCountedThreadSafe);
37 };
38
25 scoped_refptr<OpaqueRefCounted> MakeOpaqueRefCounted() { 39 scoped_refptr<OpaqueRefCounted> MakeOpaqueRefCounted() {
26 return new OpaqueRefCounted(); 40 return new OpaqueRefCounted();
27 } 41 }
28 42
29 void TestOpaqueRefCounted(scoped_refptr<OpaqueRefCounted> p) { 43 void TestOpaqueRefCounted(scoped_refptr<OpaqueRefCounted> p) {
30 EXPECT_EQ(42, p->Return42()); 44 EXPECT_EQ(42, p->Return42());
31 } 45 }
32 46
47 scoped_refptr<OpaqueRefCountedThreadSafe> MakeOpaqueRefCountedThreadSafe() {
48 return new OpaqueRefCountedThreadSafe();
49 }
50
51 void TestOpaqueRefCountedThreadSafe(
52 scoped_refptr<OpaqueRefCountedThreadSafe> p) {
53 EXPECT_EQ(42, p->Return42());
54 }
55
33 } // namespace base 56 } // namespace base
34 57
35 template class scoped_refptr<base::OpaqueRefCounted>; 58 template class scoped_refptr<base::OpaqueRefCounted>;
59 template class scoped_refptr<base::OpaqueRefCountedThreadSafe>;
OLDNEW
« no previous file with comments | « base/test/opaque_ref_counted.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698