Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2446403003: chromeos: Convert bluetooth pairing dialog to work with mash, part 1 (Closed)

Created:
4 years, 1 month ago by James Cook
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, alemate+watch_chromium.org, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Convert bluetooth pairing dialog to work with mash, part 1 Under mash code in chrome cannot directly access the ash aura window hierarchy. Instead it must pass an ash window container id when a new window is being opened. Migrate some UMA statistics from //ash to //chrome to eliminate a couple references to ash::WmShell inside chrome. BUG=657021 TEST=chrome browser_tests, also open bluetooth pairing dialog from system tray menu at login screen Committed: https://crrev.com/aa0f21bffad98b4b27d6ffff0879d2e13c0ae3c5 Cr-Commit-Position: refs/heads/master@{#427549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -38 lines) Patch
M ash/common/metrics/user_metrics_action.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.h View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui_browsertest-inl.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
stevenjb, please take a look.
4 years, 1 month ago (2016-10-25 22:00:33 UTC) #3
stevenjb
lgtm
4 years, 1 month ago (2016-10-26 00:16:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446403003/1
4 years, 1 month ago (2016-10-26 00:19:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 00:28:27 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 00:30:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa0f21bffad98b4b27d6ffff0879d2e13c0ae3c5
Cr-Commit-Position: refs/heads/master@{#427549}

Powered by Google App Engine
This is Rietveld 408576698