Set right button for mousedown/contextmenu of long press gesture

Set right button for mousedown/contextmenu of long press gesture

This CL will set the right button for the mousedown
and contextmenu events.

BUG=658499
Committed: https://crrev.com/53040d2c8ff415e4db439943247e86767a01e7be
Cr-Commit-Position: refs/heads/master@{#429091}

[Navid Zolghadr, 2016-10-25 19:43:57]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 19:44:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-10-25 20:12:04]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org

[Navid Zolghadr, 2016-10-25 20:12:37]

https://codereview.chromium.org/2446333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/GestureManager.cpp (right):

https://codereview.chromium.org/2446333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/GestureManager.cpp:408:
m_mouseEventManager->dispatchMouseClickIfNeeded(mev);
Do you think these few lines are worth adding a new function?

[commit-bot: I haz the power, 2016-10-25 20:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:44:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Navid Zolghadr, 2016-10-27 19:23:18]

nzolghadr@chromium.org changed reviewers:
+ mustaq@chromium.org

[Navid Zolghadr, 2016-10-27 19:23:19]

mustaq@ I realized that you have changed this behavior here in this CL
https://codereview.chromium.org/2249663002

regarding the button that was set for mousedown and contextmenu event of long
press gesture. I couldn't find any documentation on why this is the correct way
of doing that. Can you comment about it?

[Navid Zolghadr, 2016-10-27 20:48:05]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:49:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 21:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:11:11]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[mustaq, 2016-10-31 15:21:04]

On 2016/10/27 19:23:19, Navid Zolghadr wrote:
> mustaq@ I realized that you have changed this behavior here in this CL
> https://codereview.chromium.org/2249663002
> 
> regarding the button that was set for mousedown and contextmenu event of long
> press gesture. I couldn't find any documentation on why this is the correct
way
> of doing that. Can you comment about it?

The button=0 on mousedown in that CL is clearly wrong, sorry for the inadvertent
bug. Here is what happened there: in that CL we originally removed the mousedown
firing completely. But the skipped mousedown seemed to expose a focusing problem
in text box (gets focus w/o a cursor). So we brought it back w/o realizing that
our button=0 fix applies only to the contextmenu event, not to the mousedown.

[Navid Zolghadr, 2016-10-31 20:03:52]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 20:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-10-31 20:15:05]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 20:15:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-10-31 20:15:46]

ptal

[commit-bot: I haz the power, 2016-10-31 20:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:29:33]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mustaq, 2016-10-31 20:30:09]

LGTM % a nit etc.

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/GestureManager.cpp (right):

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/GestureManager.cpp:365: eventType =
PlatformEvent::MouseReleased;  PlatformMouseEvent mouseEvent(
Bad copy-paste?

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/GestureManager.cpp:366: PlatformMouseEvent
mouseEvent(
I should have done it, sorry: please add a comment here:
// We don't want a mousedown here but text area cursor doesn't appear on
long-tap focus w/o the mousedown. crrev.com/...

[Navid Zolghadr, 2016-11-01 16:00:44]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 16:01:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-11-01 16:27:11]

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/GestureManager.cpp (right):

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/GestureManager.cpp:365: eventType =
PlatformEvent::MouseReleased;  PlatformMouseEvent mouseEvent(
On 2016/10/31 20:30:09, mustaq wrote:
> Bad copy-paste?

Done.

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/GestureManager.cpp:366: PlatformMouseEvent
mouseEvent(
On 2016/10/31 20:30:09, mustaq wrote:
> I should have done it, sorry: please add a comment here:
> // We don't want a mousedown here but text area cursor doesn't appear on
> long-tap focus w/o the mousedown. crrev.com/...

Done.

[Navid Zolghadr, 2016-11-01 16:27:23]

nzolghadr@chromium.org changed reviewers:
+ bokan@chromium.org

[dtapuska, 2016-11-01 16:35:36]

On 2016/11/01 16:27:23, Navid Zolghadr wrote:

lgtm but I think we need to update the commit message.

[bokan, 2016-11-01 16:38:55]

On 2016/11/01 16:35:36, dtapuska wrote:
> On 2016/11/01 16:27:23, Navid Zolghadr wrote:
> 
> lgtm but I think we need to update the commit message.

lgtm % the commit message

[Navid Zolghadr, 2016-11-01 16:39:58]

Description was changed from

==========
Send mouseup and possibly auxclick on long press

We used to not send mouseup (and as the result no
auxclick) for long press as oppose to real mouse
right click. This CL will set the right button for
the mouse down (that we are already sending) as
well as sending mouseup and auxclick if necessary
for long press and double finger tap.

BUG=658499
==========

to

==========
Set right button for mousedown/contextmenu of long press gesture

This CL will set the right button for the mousedown
and contextmenu events.

BUG=658499
==========

[mustaq, 2016-11-01 17:04:42]

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/GestureManager.cpp (right):

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/GestureManager.cpp:366: PlatformMouseEvent
mouseEvent(
On 2016/11/01 16:27:11, Navid Zolghadr wrote:
> On 2016/10/31 20:30:09, mustaq wrote:
> > I should have done it, sorry: please add a comment here:
> > // We don't want a mousedown here but text area cursor doesn't appear on
> > long-tap focus w/o the mousedown. crrev.com/...
> 
> Done.

Please also add a ref to the bug I just filed: crbug.com/661200. Thanks.

[Navid Zolghadr, 2016-11-01 17:08:51]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 17:09:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-11-01 17:09:42]

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/GestureManager.cpp (right):

https://codereview.chromium.org/2446333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/GestureManager.cpp:366: PlatformMouseEvent
mouseEvent(
On 2016/11/01 17:04:42, mustaq wrote:
> On 2016/11/01 16:27:11, Navid Zolghadr wrote:
> > On 2016/10/31 20:30:09, mustaq wrote:
> > > I should have done it, sorry: please add a comment here:
> > > // We don't want a mousedown here but text area cursor doesn't appear on
> > > long-tap focus w/o the mousedown. crrev.com/...
> > 
> > Done.
> 
> Please also add a ref to the bug I just filed: crbug.com/661200. Thanks.

Done.

[Navid Zolghadr, 2016-11-01 17:29:57]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-11-01 17:30:02]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-11-01 17:30:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org,
dtapuska@chromium.org, bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2446333002/#ps100001
(title: "Add the bug ref for focus")

[commit-bot: I haz the power, 2016-11-01 17:30:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 20:28:32]

Description was changed from

==========
Set right button for mousedown/contextmenu of long press gesture

This CL will set the right button for the mousedown
and contextmenu events.

BUG=658499
==========

to

==========
Set right button for mousedown/contextmenu of long press gesture

This CL will set the right button for the mousedown
and contextmenu events.

BUG=658499
==========

[commit-bot: I haz the power, 2016-11-01 20:28:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-01 20:32:36]

Description was changed from

==========
Set right button for mousedown/contextmenu of long press gesture

This CL will set the right button for the mousedown
and contextmenu events.

BUG=658499
==========

to

==========
Set right button for mousedown/contextmenu of long press gesture

This CL will set the right button for the mousedown
and contextmenu events.

BUG=658499

Committed: https://crrev.com/53040d2c8ff415e4db439943247e86767a01e7be
Cr-Commit-Position: refs/heads/master@{#429091}
==========

[commit-bot: I haz the power, 2016-11-01 20:32:37]

Patchset 6 (id:??) landed as
https://crrev.com/53040d2c8ff415e4db439943247e86767a01e7be
Cr-Commit-Position: refs/heads/master@{#429091}