Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 2446323003: Add tests while FullscreenUnprefixed flag is turned off. (Closed)

Created:
4 years, 1 month ago by kochi
Modified:
4 years, 1 month ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests while FullscreenUnprefixed flag is turned off. Adds test cases for fullscreenElement retargeting, when FullscreenUnprefixed runtime enabled flag is turned off. Document.webkitFullscreenElement and .webkitCurrentFullScreenElement changes behavior depending on the flag, and when it is turned off, it keeps compatibility with the current behavior (not retargeting fullscreen element when it is in a shadow tree). The behavior when the flag is on is already covered in the previous CL: https://codereview.chromium.org/2340263003/ BUG=622585 Committed: https://crrev.com/bf66552a405a371dc840136ba216d67f82802883 Cr-Commit-Position: refs/heads/master@{#429206}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/shadow-dom/fullscreen-element-in-shadow-complex.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/fullscreen-element-in-shadow-simple.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v0/fullscreen-element-in-v0.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
kochi
foolip@, could you take a look? I found a way to turn off FullscreenUnprefixed flag ...
4 years, 1 month ago (2016-10-26 06:54:59 UTC) #3
kochi
Ping?
4 years, 1 month ago (2016-10-28 09:44:18 UTC) #4
foolip
lgtm Apologies for not getting to this sooner, and thanks for testing both behaviors!
4 years, 1 month ago (2016-11-01 20:40:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446323003/1
4 years, 1 month ago (2016-11-01 20:41:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/59711) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-01 20:44:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446323003/20001
4 years, 1 month ago (2016-11-02 02:28:42 UTC) #12
kochi
On 2016/11/01 20:40:49, foolip wrote: > lgtm > > Apologies for not getting to this ...
4 years, 1 month ago (2016-11-02 02:31:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 04:16:55 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 04:19:07 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf66552a405a371dc840136ba216d67f82802883
Cr-Commit-Position: refs/heads/master@{#429206}

Powered by Google App Engine
This is Rietveld 408576698